Replace the discontinued mapstruct-jdk8 artifact before upgrading the MapStruct version - #1260
Merged
Merged
Conversation
…e version upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Java 17 migration raises the shared
mapstruct.versionproperty to 1.6.x, butorg.mapstruct:mapstruct-jdk8was discontinued after 1.3, so the project ends up asking for a version that does not exist. The migration now first changes the artifact toorg.mapstruct:mapstruct.Found by a team of coding agents reviewing a Moderne run of
org.openrewrite.java.spring.boot4.UpgradeSpringBoot_4_0over the 31 JHipster repositories (run 20261003115037-NUeOz). The issue ismapstruct-jdk8-artifact-retainedin the run'sio.moderne.RecipeIssuesdata table (4 rows), and the fix was discussed and reviewed on the run's message board. A row from the table, as a generalized example:Updating the shared MapStruct version leaves the discontinued mapstruct-jdk8 artifact at a nonexistent version. (
jhipster/jhipster-sample-app-ng1,pom.xml, recipeorg.openrewrite.java.dependencies.UpgradeDependencyVersion)Before:
What the recipe produced:
Expected:
First of a stack of 3 pull requests from the same review; each later one is based on the one before it.