The Jakarta migration updates Jakarta EE type names in string literals - #1271
Merged
Merged
Conversation
jkschneider
force-pushed
the
jakarta/reflective-type-names
branch
from
October 3, 2026 22:26
2bce03c to
d964eae
Compare
…vlet packages and the Java version (#1274) * jetty-ee9-java-baseline: align Jetty dependencies packages and Java baseline * jetty-ee9-java-baseline: leave standalone Jetty utility dependencies unchanged * jetty-ee9-java-baseline: require a direct dependency before upgrading Java
…on properties when relocating artifacts (#1275) * jackson-version-downgrade: preserve newer versions and shared properties * jackson-shared-version-property-split: cover older shared Jackson versions
…ian Recorder 1.x binaries (#1276) * recorder-javax-jaxb-api-removed: retain the API needed by Recorder binaries * recorder-javax-jaxb-api-removed: limit retention to external binaries after migration
… it again in compile scope (#1279) * cdi-provided-scope-promoted: preserve provided CDI API scope * cdi-provided-scope-promoted: distinguish provided declarations from runtime APIs * provided-api-scope-overwritten: preserve provided Mail API scope * provided-api-scope-overwritten: preserve container API scopes across Jakarta migrations
…oviderBase._configForWriting` overrides (#1280) * jackson-provider-override-signature: forward the default view parameter * jackson-provider-override-signature: update callers of migrated overrides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChangePackagemoves imports but leaves class names in string literals, so code that looks types up by name, such as Arquillian's test enrichers checking for"javax.inject.Inject"or"javax.ejb.EJB", or that writes aservices/javax.enterprise.inject.spi.Extensiondescriptor, silently stopped finding the migrated APIs. New declarative recipeJavaxRuntimeTypeNamesToJakarta, run early inJavaxMigrationToJakarta, appliesChangePackageInStringLiteraltojavax.inject,javax.enterprise,javax.ejbandjavax.servlet, andChangeTypeInStringLiteraltojavax.annotation.Resourceandjavax.annotation.Resources. It is limited to those names on purpose, so strings naming Java SE packages that stay injavax, such asjavax.annotation.processing,javax.naming,javax.net.sslandjavax.transaction.xa, are left alone.Found by a team of coding agents reviewing a Moderne run of
org.openrewrite.java.migrate.jakarta.JavaxMigrationToJakartaover the 31 Arquillian repositories (run 20261003120559-YQoma). The issues arejavax-reflective-names-retainedin the run'sio.moderne.RecipeIssuesdata table (21 rows) andcdi-service-path-literal-retained(2 rows), and the fix was discussed and reviewed on the run's message board. A row from the table, as a generalized example:Unmigrated runtime class names disable Jakarta availability checks or annotation recognition. (
arquillian/arquillian-core,testenrichers/cdi/src/main/java/org/jboss/arquillian/testenricher/cdi/CDIInjectionEnricher.java, recipeorg.openrewrite.java.migrate.jakarta.JavaxMigrationToJakarta)Before:
What the recipe produced:
Expected:
Stacked on #1270 (8 of 19); merge that one first.