Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
/*
* Copyright 2024 the original author or authors.
* <p>
* Licensed under the Moderne Source Available License (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* <p>
* https://docs.moderne.io/licensing/moderne-source-available-license
* <p>
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.openrewrite.java.migrate.jakarta;

import lombok.Getter;
import org.openrewrite.Cursor;
import org.openrewrite.ExecutionContext;
import org.openrewrite.Recipe;
import org.openrewrite.Tree;
import org.openrewrite.TreeVisitor;
import org.openrewrite.internal.ListUtils;
import org.openrewrite.java.JavaIsoVisitor;
import org.openrewrite.java.JavaTemplate;
import org.openrewrite.java.MethodMatcher;
import org.openrewrite.java.VariableNameUtils;
import org.openrewrite.java.tree.Expression;
import org.openrewrite.java.tree.J;
import org.openrewrite.java.tree.JavaType;
import org.openrewrite.java.tree.Space;
import org.openrewrite.marker.Markers;

public class JacksonProviderOverrides extends Recipe {
@Getter
final String displayName = "Migrate Jackson provider configuration overrides";
@Getter
final String description = "Add and forward the default view parameter required by Jakarta Jackson providers.";

@Override
public TreeVisitor<?, ExecutionContext> getVisitor() {
return new JavaIsoVisitor<ExecutionContext>() {
final MethodMatcher oldMethod = new MethodMatcher(
"com.fasterxml.jackson.jaxrs.base.ProviderBase _configForWriting(com.fasterxml.jackson.databind.ObjectMapper, java.lang.annotation.Annotation[])", true);

@Override
public J.MethodDeclaration visitMethodDeclaration(J.MethodDeclaration method, ExecutionContext ctx) {
if (!oldMethod.matches(method.getMethodType()) || method.getParameters().size() != 2) {
return super.visitMethodDeclaration(method, ctx);
}
String viewName = VariableNameUtils.generateVariableName("defaultView", getCursor(),
VariableNameUtils.GenerationStrategy.INCREMENT_NUMBER);
J.MethodDeclaration m = JavaTemplate.builder("#{}, #{}, Class<?> " + viewName).contextSensitive().build()
.apply(getCursor(), method.getCoordinates().replaceParameters(),
method.getParameters().get(0).printTrimmed(getCursor()),
method.getParameters().get(1).printTrimmed(getCursor()));
m = m.withParameters(ListUtils.concat(method.getParameters(), m.getParameters().get(2)));
J.VariableDeclarations.NamedVariable view = ((J.VariableDeclarations) m.getParameters().get(2)).getVariables().get(0);
JavaType.Method updatedType = addView(method.getMethodType(), view.getType(), viewName);
m = m.withMethodType(updatedType).withName(m.getName().withType(updatedType));
updateCursor(m).putMessage("jacksonDefaultView", view.getName());
return super.visitMethodDeclaration(m, ctx);
}

@Override
public J.MethodInvocation visitMethodInvocation(J.MethodInvocation invocation, ExecutionContext ctx) {
J.MethodInvocation mi = super.visitMethodInvocation(invocation, ctx);
if (!oldMethod.matches(mi)) {
return mi;
}
Cursor methodCursor = getCursor().dropParentUntil(value -> value instanceof J.MethodDeclaration || value instanceof J.CompilationUnit);
J.Identifier view = methodCursor.getMessage("jacksonDefaultView");
Expression argument = view == null ?
new J.Literal(Tree.randomId(), Space.SINGLE_SPACE, Markers.EMPTY, null, "null", null, JavaType.Primitive.Null) :
view.withId(Tree.randomId()).withPrefix(Space.SINGLE_SPACE);
JavaType.Method updatedType = addView(mi.getMethodType(), JavaType.buildType("java.lang.Class"), "defaultView");
return mi.withArguments(ListUtils.concat(mi.getArguments(), argument)).withMethodType(updatedType)
.withName(mi.getName().withType(updatedType));
}

private JavaType.Method addView(JavaType.Method method, JavaType type, String name) {
return method.withParameterTypes(ListUtils.concat(method.getParameterTypes(), type))
.withParameterNames(ListUtils.concat(method.getParameterNames(), name));
}
};
}
}
1 change: 1 addition & 0 deletions src/main/resources/META-INF/rewrite/jakarta-ee-9.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1259,6 +1259,7 @@ description: >-
preconditions:
- org.openrewrite.Singleton
recipeList:
- org.openrewrite.java.migrate.jakarta.JacksonProviderOverrides
# Raise older versions before changing coordinates, preserving newer versions and shared properties.
- org.openrewrite.java.dependencies.UpgradeDependencyVersion:
groupId: com.fasterxml.jackson.module
Expand Down
Loading