Skip to content

chore: replace bingo with Go 1.24 tool directives#239

Draft
kuudori wants to merge 1 commit into
openshift-hyperfleet:mainfrom
kuudori:chore/replace-bingo-with-go-tool-directives
Draft

chore: replace bingo with Go 1.24 tool directives#239
kuudori wants to merge 1 commit into
openshift-hyperfleet:mainfrom
kuudori:chore/replace-bingo-with-go-tool-directives

Conversation

@kuudori

@kuudori kuudori commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

HYPERFLEET-1331

Remove bingo tool management in favor of native tool directives in go.mod (Go 1.24+).
Tool versions are pinned in go.mod/go.sum and resolved via go tool <name>.

Pinned versions (unchanged from bingo):

  • goimports v0.40.0 → golang.org/x/tools (resolved to v0.47.0 via MVS)
  • golangci-lint v2.7.0 → github.com/golangci/golangci-lint/v2 (resolved to v2.12.2 via MVS)
  • helm-docs v1.14.2 → github.com/norwoodj/helm-docs v1.14.2
  • kubeconform v0.7.0 → github.com/yannh/kubeconform (resolved to v0.8.0 via MVS)

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pnguyen44 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (2)
  • do-not-merge/work-in-progress
  • do-not-merge/hold

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: bd773ce0-cded-4fef-9bc2-d5ce117dcd67

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

@kuudori kuudori force-pushed the chore/replace-bingo-with-go-tool-directives branch 2 times, most recently from 1f789e0 to c3b37e9 Compare July 10, 2026 19:10
@kuudori kuudori force-pushed the chore/replace-bingo-with-go-tool-directives branch from c3b37e9 to 5667250 Compare July 10, 2026 19:32
@kuudori kuudori marked this pull request as ready for review July 10, 2026 19:40
@openshift-ci openshift-ci Bot requested review from ciaranRoche and rh-amarin July 10, 2026 19:40
@hyperfleet-ci-bot

Copy link
Copy Markdown

Risk Score: 2 — risk/medium

Signal Detail Points
PR size 1773 lines (>500) +2
Sensitive paths none +0

Computed by hyperfleet-risk-scorer

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

@kuudori: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-commits 5667250 link true /test validate-commits
ci/prow/lint 5667250 link true /test lint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kuudori kuudori marked this pull request as draft July 13, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant