HYPERFLEET-1651 - ci: prefetch tools module for Hermeto - #268
ciaranRoche merged 1 commit into
Conversation
The push and tag pipelines prefetch only the root Go module, but make build runs the code generator through go tool -modfile=tools/go.mod. Hermeto points GOPROXY at its prefetch output, so oapi-codegen is missing and every on-push build has failed since the prefetch was added. Prefetch the tools module as a second gomod path so the generator resolves and its packages carry Hermeto attribution. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018EkLeTwdmrofNMwKRpDCWG
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe push and tag Tekton pipeline configurations now prefetch Go modules from Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The push and tag builds prefetch both Go modules before building, with no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Risk Score: 0 —
|
| Signal | Detail | Points |
|---|---|---|
| PR size | 4 lines | +0 |
| Sensitive paths | none | +0 |
Computed by hyperfleet-risk-scorer
Summary
Prefetches the
toolsGo module alongside the root module in the push and tag pipelines.make buildruns the code generator throughgo tool -modfile=tools/go.mod. The Hermeto prefetch added on 2026-09-04 covers only the root module, and Hermeto pointsGOPROXYat its prefetch output, so the build fails withoapi-codegen/v2@v2.7.2: ... no such file or directory. No on-push image has been produced since that change.The build stays non-hermetic. Prefetching
toolsalso gives its packages the Hermeto attribution the Conforma SBOM rule requires from 2026-10-01.Validation
go mod download allinsidetools/resolves every module with no errors, which is the resolution Hermeto performsgit diff --checkcleanRefs HYPERFLEET-1651
🤖 Generated with Claude Code
https://claude.ai/code/session_018EkLeTwdmrofNMwKRpDCWG