Skip to content

CORS-4523: support GCP custom universe domain#249

Open
patrickdillon wants to merge 4 commits into
openshift:mainfrom
patrickdillon:gcd-auth
Open

CORS-4523: support GCP custom universe domain#249
patrickdillon wants to merge 4 commits into
openshift:mainfrom
patrickdillon:gcd-auth

Conversation

@patrickdillon

Copy link
Copy Markdown
Contributor

Enables support for custom universe domains in GCP (read from the credentials), which enables support for Google Cloud Dedicated, GCP's sovereign cloud offering.

Also updates GCP auth functions to non-deprecated types.

See openshift/enhancements#1977 for more details.

Sets the universe doamin in GCP, which is necessary for any
GCP environment not using the default universe domain. Particularly
we are targeting Google Dedicated Cloud (GDC), the sovereign cloud
offering.
Update to latest google api packages in order to get most up-to-date
authentication libraries.
go mod tidy && go mod vendor
Updates from WithCredentialsJSON -> WithAuthCredentialsJSON
and FromCredentialsJSON -> FromCredentialsJSONWithType to avoid
using the deprecated function. This change is a no-op, only
intended to avoid deprecation.

The new functions takes a credential type parameter, which can be
used to limit accepted credentials types, which is useful for
validating credentials provided by external third parties.

For OpenShift, cluster credentials are coming from first party users
running clusters in their project, so we do not need to limit which
credentials are accepted; therefore we just pass the type through
from the credential to the function.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 21, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 21, 2026

Copy link
Copy Markdown

@patrickdillon: This pull request references CORS-4523 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Enables support for custom universe domains in GCP (read from the credentials), which enables support for Google Cloud Dedicated, GCP's sovereign cloud offering.

Also updates GCP auth functions to non-deprecated types.

See openshift/enhancements#1977 for more details.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Bug Fixes

    • Improved Google Cloud authentication by supporting typed credential configurations.
    • Enhanced compatibility with Google Cloud environments using custom universe domains.
  • Chores

    • Updated underlying Google Cloud, OpenTelemetry, and Go library dependencies for improved compatibility and maintenance.

Walkthrough

GCP credential initialization now parses typed Google credential JSON, retrieves its universe domain, and configures client options with both values. The module graph is updated for newer OAuth, Google API, OpenTelemetry, gRPC, and related indirect dependencies.

Changes

GCP credential initialization

Layer / File(s) Summary
Typed credentials and dependency updates
pkg/cloudprovider/gcp.go, go.mod
initCredentials extracts the credential type, creates typed credentials, obtains the universe domain, and uses WithAuthCredentialsJSON with WithUniverseDomain; related indirect modules are updated.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant initCredentials
  participant goauth
  participant GoogleClientOptions
  initCredentials->>goauth: parse credential type and create credentials
  goauth-->>initCredentials: credentials and universe domain
  initCredentials->>GoogleClientOptions: configure auth JSON and universe domain
Loading
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed It clearly summarizes the main change: adding support for GCP custom universe domains.
Description check ✅ Passed It directly describes the PR's GCP universe domain and auth updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR changes only go.mod/go.sum, gcp.go, and vendored deps; no *_test.go files or Ginkgo titles were added or modified.
Test Structure And Quality ✅ Passed PR changes only pkg/cloudprovider/gcp.go; no Ginkgo test files or test code were modified, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed Only pkg/cloudprovider/gcp.go changed; no Ginkgo test constructs or new e2e tests were added, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only pkg/cloudprovider/gcp.go changed; no *_test.go/e2e files or new Ginkgo tests were added, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only changes GCP credential parsing/client setup; no manifests, controllers, affinity, selectors, or replica logic were added.
Ote Binary Stdout Contract ✅ Passed PR only adds klog logging inside helper methods in pkg/cloudprovider/gcp.go; no new stdout writes in main/init/TestMain/top-level code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only touches pkg/cloudprovider/gcp.go and go.mod, so this check is not applicable.
No-Weak-Crypto ✅ Passed PASS: The patch only updates GCP credential handling; no weak algorithms, custom crypto, or non-constant-time secret/token comparisons are introduced.
Container-Privileges ✅ Passed PR only changes pkg/cloudprovider/gcp.go auth logic; no container/K8s manifests or privilege-related fields were added.
No-Sensitive-Data-In-Logs ✅ Passed No new logs expose secrets; added messages only note credential source/path and default universe domain, not passwords/tokens/PII.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jcaamano and miheer July 21, 2026 15:22
@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: patrickdillon
Once this PR has been reviewed and has the lgtm label, please assign kyrtapz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/cloudprovider/gcp.go`:
- Around line 56-76: Update the credential parsing flow around the local
credential-type struct and goauth.CredentialsFromJSONWithType to validate the
complete credentials JSON before creating credentials or client options: allow
only the intended credential types, permit only the expected universe domain,
and reject untrusted URL-bearing fields in external_account and
impersonated_service_account configurations. Return descriptive validation
errors and ensure the validated values are the only ones passed to
option.WithAuthCredentialsJSON and option.WithUniverseDomain.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e1f13c86-11d9-4a79-a761-a54b23e2f6a7

📥 Commits

Reviewing files that changed from the base of the PR and between 0b49df2 and e82d648.

⛔ Files ignored due to path filters (527)
  • go.sum is excluded by !**/*.sum
  • vendor/cloud.google.com/go/auth/CHANGES.md is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/README.md is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/auth.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/compute.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/detect.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/filetypes.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/aws_provider.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/externalaccount.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/url_provider.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/x509_provider.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/internal/externalaccountuser/externalaccountuser.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/internal/gdch/gdch.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/internal/impersonate/idtoken.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/internal/impersonate/impersonate.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/internal/stsexchange/sts_exchange.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/selfsignedjwt.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/httptransport/httptransport.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/httptransport/trace.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/httptransport/transport.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/credsfile/credsfile.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/credsfile/filetype.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/credsfile/parse.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/internal.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/jwt/jwt.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/retry/retry.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/transport/cba.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/transport/cert/default_cert.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/transport/cert/enterprise_cert.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/transport/cert/secureconnect_cert.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/transport/cert/workload_cert.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/transport/headers/headers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/transport/s2a.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/transport/transport.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/trustboundary/external_accounts_config_providers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/trustboundary/trust_boundary.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/oauth2adapt/CHANGES.md is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/oauth2adapt/oauth2adapt.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/threelegged.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/compute/metadata/CHANGES.md is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/compute/metadata/metadata.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/compute/metadata/retry.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/compute/metadata/syscheck.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/compute/metadata/syscheck_linux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/compute/metadata/syscheck_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/groupcache/LICENSE is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/groupcache/lru/lru.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/AUTHORS is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/CONTRIBUTORS is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/LICENSE is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/proto/buffer.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/proto/defaults.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/proto/deprecated.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/proto/discard.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/proto/extensions.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/proto/properties.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/proto/proto.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/proto/registry.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/proto/text_decode.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/proto/text_encode.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/proto/wire.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/golang/protobuf/proto/wrappers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/internal/proto/common_go_proto/common.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/internal/proto/s2a_context_go_proto/s2a_context.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/internal/proto/s2a_go_proto/s2a.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/internal/proto/s2a_go_proto/s2a_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/internal/proto/v2/common_go_proto/common.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/internal/proto/v2/s2a_context_go_proto/s2a_context.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/internal/proto/v2/s2a_go_proto/s2a.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/internal/proto/v2/s2a_go_proto/s2a_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/internal/record/record.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/internal/tokenmanager/tokenmanager.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/internal/v2/s2av2.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/tlsconfigstore.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/s2a.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/s2a_options.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/google/s2a-go/stream/s2a_stream.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/enterprise-certificate-proxy/client/client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/enterprise-certificate-proxy/client/util/util.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/.release-please-manifest.json is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/CHANGES.md is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/apierror/apierror.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/apierror/internal/proto/custom_error.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/apierror/internal/proto/error.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/call_option.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/callctx/callctx.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/content_type.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/feature.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/header.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/internal/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/internallog/internal/internal.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/internallog/internallog.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/invoke.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/googleapis/gax-go/v2/telemetry.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/.gitignore is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/AUTHORS is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/CONTRIBUTING.md is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/LICENSE is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/Makefile is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/README.md is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/appveyor.yml is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/internal/internal.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/internal/sanitize.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/internal/tagencoding/tagencoding.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/internal/traceinternals.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/metric/metricdata/doc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/metric/metricdata/exemplar.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/metric/metricdata/label.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/metric/metricdata/metric.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/metric/metricdata/point.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/metric/metricdata/type_string.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/metric/metricdata/unit.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/metric/metricproducer/manager.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/metric/metricproducer/producer.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/opencensus.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/plugin/ochttp/client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/plugin/ochttp/client_stats.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/plugin/ochttp/doc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/plugin/ochttp/propagation/b3/b3.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/plugin/ochttp/route.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/plugin/ochttp/server.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/plugin/ochttp/span_annotating_client_trace.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/plugin/ochttp/stats.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/plugin/ochttp/trace.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/plugin/ochttp/wrapped_body.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/resource/resource.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/doc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/internal/record.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/measure.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/measure_float64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/measure_int64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/record.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/units.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/view/aggregation.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/view/aggregation_data.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/view/collector.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/view/doc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/view/export.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/view/view.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/view/view_to_metric.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/view/worker.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/stats/view/worker_commands.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/tag/context.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/tag/doc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/tag/key.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/tag/map.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/tag/map_codec.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/tag/metadata.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/tag/profile_19.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/tag/validate.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/basetypes.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/doc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/evictedqueue.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/export.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/internal/internal.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/lrumap.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/propagation/propagation.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/sampling.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/spanbucket.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/spanstore.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/status_codes.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/trace.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/trace_api.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/trace_go11.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/trace_nongo11.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opencensus.io/trace/tracestate/tracestate.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/id.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/number.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/span.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/status.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/traces.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/auto/sdk/internal/telemetry/value.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/auto/sdk/span.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/auto/sdk/tracer.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/LICENSE is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/common.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/doc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/handler.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/request/resp_writer_wrapper.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconv/client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconv/env.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconv/gen.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconv/httpconv.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconv/server.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconv/util.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconv/v1.20.0.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconvutil/gen.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconvutil/httpconv.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconvutil/netconv.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/transport.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/.clomonitor.yml is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/.codespellignore is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/.golangci.yml is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/.lycheeignore is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/CODEOWNERS is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/CONTRIBUTING.md is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/LICENSE is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/Makefile is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/README.md is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/RELEASING.md is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/SECURITY-INSIGHTS.yml is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/VERSIONING.md is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/encoder.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/filter.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/hash.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/internal/attribute.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/internal/xxhash/xxhash.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/iterator.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/key.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/kv.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/set.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/type_string.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/attribute/value.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/baggage/baggage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/codes/codes.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/dependencies.Dockerfile is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/internal/errorhandler/errorhandler.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/internal/global/handler.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/internal/global/instruments.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/internal/global/internal_logging.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/internal/global/meter.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/internal/global/state.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/internal/global/trace.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/metric.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/metric/LICENSE is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/metric/asyncfloat64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/metric/asyncint64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/metric/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/metric/meter.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/metric/noop/noop.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/metric/syncfloat64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/metric/syncint64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/propagation/baggage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/propagation/propagation.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/propagation/trace_context.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/requirements.txt is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.20.0/README.md is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.20.0/attribute_group.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.20.0/event.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.20.0/http.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.20.0/resource.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.20.0/trace.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.26.0/README.md is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.26.0/attribute_group.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.26.0/metric.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.37.0/MIGRATION.md is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.37.0/README.md is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.37.0/attribute_group.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.37.0/doc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.37.0/error_type.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.37.0/exception.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.37.0/schema.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.40.0/MIGRATION.md is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.40.0/README.md is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.40.0/attribute_group.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.40.0/doc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.40.0/error_type.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.40.0/exception.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.40.0/httpconv/metric.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/semconv/v1.40.0/schema.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/trace/LICENSE is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/trace/auto.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/trace/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/trace/hex.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/trace/internal/telemetry/attr.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/trace/internal/telemetry/id.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/trace/internal/telemetry/value.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/trace/noop.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/trace/noop/noop.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/trace/span.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/trace/trace.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/trace/tracestate.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.opentelemetry.io/otel/versions.yaml is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/crypto/chacha20poly1305/chacha20poly1305_amd64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/crypto/chacha20poly1305/chacha20poly1305_amd64.s is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/crypto/hkdf/hkdf.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/crypto/pkcs12/crypto.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/crypto/pkcs12/mac.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/html/entity.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/html/escape.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/html/foreign.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/html/iter.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/html/parse.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/html/render.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/html/token.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/README.md is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/client_conn_pool.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/clientconn.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/frame.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/http2.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/server.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/server_common.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/server_wrap.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/transport.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/transport_common.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/transport_wrap.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/writesched.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/writesched_common.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/writesched_priority_rfc7540.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/writesched_priority_rfc9218.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/writesched_random.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/http2/writesched_roundrobin.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/idna/go118.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/idna/idna.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/idna/idna9.0.0.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/idna/pre_go118.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/idna/punycode.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/idna/tables10.0.0.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/idna/tables11.0.0.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/idna/tables12.0.0.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/idna/tables13.0.0.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/idna/tables15.0.0.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/idna/tables17.0.0.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/idna/tables9.0.0.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/idna/trie12.0.0.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/idna/trie13.0.0.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/net/internal/httpcommon/request.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/asm_darwin_arm64_gc.s is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/cpu.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_arm64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_darwin_arm64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_darwin_arm64_other.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_gccgo_arm64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_linux_riscv64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_loong64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_other_arm64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_riscv64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/cpu_windows_arm64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/syscall_darwin_arm64_gc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/cpu/zcpu_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/plan9/syscall_plan9.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/affinity_linux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/mkall.sh is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/mkerrors.sh is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/readv_unix.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/syscall_darwin.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/syscall_linux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/syscall_linux_arm.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/syscall_linux_arm64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/syscall_linux_loong64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/syscall_linux_riscv64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/syscall_openbsd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_386.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_amd64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_arm.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_arm64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_loong64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_mips.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_mips64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_mips64le.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_mipsle.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_ppc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_ppc64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_ppc64le.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_riscv64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_s390x.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_sparc64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_linux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_openbsd_386.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_openbsd_386.s is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_openbsd_amd64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_openbsd_amd64.s is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm.s is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm64.s is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_openbsd_mips64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_openbsd_mips64.s is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_openbsd_ppc64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_openbsd_ppc64.s is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_openbsd_riscv64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsyscall_openbsd_riscv64.s is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_386.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_amd64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_arm.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_arm64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_loong64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_mips.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_mips64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_mips64le.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_mipsle.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_ppc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_ppc64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_ppc64le.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_riscv64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_s390x.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/zsysnum_linux_sparc64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_386.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_amd64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_arm.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_arm64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_loong64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_mips.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_mips64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_mips64le.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_mipsle.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_ppc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_ppc64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_ppc64le.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_riscv64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_s390x.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_sparc64.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/windows/aliases.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/windows/dll_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/windows/registry/key.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/windows/security_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/windows/syscall_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/windows/types_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/golang.org/x/sys/windows/zsyscall_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/compute/v1/compute-api.json is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/compute/v1/compute-gen.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/compute/v1/compute2-gen.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/compute/v1/compute3-gen.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/googleapi/googleapi.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/internal/cba.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/internal/credentialstype/credentialstype.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/internal/creds.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/internal/gensupport/buffer.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/internal/gensupport/media.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/internal/gensupport/resumable.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/internal/gensupport/retry.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/internal/gensupport/retryable_linux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/internal/gensupport/send.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/internal/settings.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/internal/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/option/internaloption/internaloption.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/option/internaloption/unsaferesolver.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/option/option.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/transport/http/dial.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/api/transport/http/internal/propagation/http.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/genproto/googleapis/rpc/code/code.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/google.golang.org/genproto/googleapis/rpc/errdetails/error_details.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/google.golang.org/genproto/googleapis/rpc/status/status.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/CONTRIBUTING.md is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/MAINTAINERS.md is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/README.md is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/attributes/attributes.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/balancer/balancer.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/balancer/base/balancer.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/balancer/endpointsharding/endpointsharding.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/balancer/pickfirst/internal/internal.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/balancer/pickfirst/pickfirst.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/balancer/pickfirst/pickfirstleaf/pickfirstleaf.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/balancer/roundrobin/roundrobin.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/balancer/subconn.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/balancer_wrapper.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/binarylog/grpc_binarylog_v1/binarylog.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/clientconn.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/credentials/credentials.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/credentials/insecure/insecure.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/credentials/tls.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/dialoptions.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/encoding/encoding.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/encoding/internal/internal.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/encoding/proto/proto.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/experimental/balancer/weight/weight.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/experimental/stats/metricregistry.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/experimental/stats/metrics.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/interceptor.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/balancer/gracefulswitch/gracefulswitch.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/buffer/unbounded.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/channelz/trace.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/credentials/credentials.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/envconfig/envconfig.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/envconfig/xds.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/experimental.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/grpcsync/callback_serializer.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/grpcsync/event.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/grpcutil/encode_duration.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/idle/idle.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/internal.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/mem/buffer_pool.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/resolver/config_selector.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/resolver/delegatingresolver/delegatingresolver.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/resolver/dns/dns_resolver.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/stats/labels.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/stats/metrics_recorder_list.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/stats/stats.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/status/status.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/transport/client_stream.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/transport/controlbuf.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/transport/defaults.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/transport/flowcontrol.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/transport/handler_server.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/transport/http2_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/transport/http2_server.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/transport/http_util.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/transport/internal/internal.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/transport/readyreader/raw_conn_linux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/transport/readyreader/raw_conn_nonlinux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/transport/readyreader/ready_reader.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/transport/server_stream.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/internal/transport/transport.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/mem/buffer_pool.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/mem/buffer_slice.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/mem/buffers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/picker_wrapper.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/preloader.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/resolver/map.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/resolver/resolver.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/resolver_wrapper.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/rpc_util.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/server.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/stats/handlers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/stats/stats.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/stream.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/grpc/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/protobuf/internal/editionssupport/editions.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/protobuf/reflect/protodesc/desc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/protobuf/reflect/protodesc/desc_init.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/protobuf/reflect/protodesc/desc_resolve.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/protobuf/reflect/protodesc/desc_validate.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/protobuf/reflect/protodesc/editions.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/protobuf/reflect/protodesc/proto.go is excluded by !vendor/**, !**/vendor/**
  • vendor/google.golang.org/protobuf/types/gofeaturespb/go_features.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/modules.txt is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (2)
  • go.mod
  • pkg/cloudprovider/gcp.go

Comment thread pkg/cloudprovider/gcp.go
@patrickdillon

Copy link
Copy Markdown
Contributor Author

/cc @kyrtapz

I recall you touched universe domain before

@openshift-ci
openshift-ci Bot requested a review from kyrtapz July 21, 2026 15:34
@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hypershift-e2e-aks e82d648 link true /test hypershift-e2e-aks
ci/prow/e2e-aws-ovn e82d648 link true /test e2e-aws-ovn
ci/prow/e2e-gcp-ovn e82d648 link true /test e2e-gcp-ovn
ci/prow/security e82d648 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Comment thread pkg/cloudprovider/gcp.go

opts := []option.ClientOption{
option.WithCredentialsJSON(credentialsJSON),
option.WithAuthCredentialsJSON(option.CredentialsType(f.Type), credentialsJSON),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we first bump the apis and go.mod updates then combine the first commit and this one? It gets the job done, but it there a need to have them separated (for backports or other events?)

Comment thread pkg/cloudprovider/gcp.go
}
ud, err := creds.GetUniverseDomain()
if err != nil {
return fmt.Errorf("error: cannot get universe domain from credentials: %w", err)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice — ensureUniverseDomain (called earlier at line 51) means GetUniverseDomain() will always find the field in the credential JSON and never fall back to querying the GCE metadata server at 169.254.169.254. This is important since the CNCC pod can't reach the metadata server.

The other sovereign cloud PRs doing the same GetUniverseDomain() pattern don't have this guard:

If those pods also can't reach the metadata server and the credentials JSON doesn't have universe_domain set, GetUniverseDomain() could hang or error instead of returning the default. Worth checking whether those operators need a similar ensureUniverseDomain guard, or if they run in a context where the metadata server is accessible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants