Skip to content

REPLACE-WITH-JIRA-KEY: Rebase k8s dependencies to v1.36.2 - #250

Closed
dfarrell07 wants to merge 1 commit into
openshift:mainfrom
dfarrell07:bump1.36-20260721174959
Closed

REPLACE-WITH-JIRA-KEY: Rebase k8s dependencies to v1.36.2#250
dfarrell07 wants to merge 1 commit into
openshift:mainfrom
dfarrell07:bump1.36-20260721174959

Conversation

@dfarrell07

@dfarrell07 dfarrell07 commented Jul 21, 2026

Copy link
Copy Markdown

Summary

  • Bump all k8s.io/* dependencies from v0.35.0 to v0.36.2 (Kubernetes 1.35 → 1.36)
  • Bump Go version from 1.25.0 to 1.26.0
  • Bump sigs.k8s.io/controller-runtime from v0.23.1 to v0.24.1
  • Update Dockerfile and .ci-operator.yaml to golang-1.26-openshift-5.0

What changed

This is a clean dependency-only rebase — no source code changes were required.
The k8s 1.36 API is fully backward-compatible with this controller's usage.

Category Details
k8s.io/* deps v0.35.0 → v0.36.2 (8 modules)
Go version 1.25.0 → 1.26.0
controller-runtime v0.23.1 → v0.24.1
OpenShift deps api, client-go, library-go updated to latest
Removed dep github.com/gogo/protobuf (k8s completed migration)
New feature gates AtomicFIFO, ClientsAllowCARotation, ClientsAllowTLSCacheGC, InOrderInformers, UnlockWhileProcessingFIFO (all default-true, no code changes needed)

Commits

  • 82db4680 Rebase k8s-rebase-1.36.2 to k8s 1.36 (mechanical dep bump)

Verification

All checks passed locally:

  • go build ./... PASS
  • go vet ./... PASS
  • golangci-lint PASS
  • staticcheck -checks SA1019 PASS (zero deprecated API calls)
  • Unit tests PASS (all 3 test packages: cloudprivateipconfig, cloudprovider, controller/cloudprivateipconfig)
  • go mod verify PASS (vendor consistent)
  • No CVEs found in bumped dependencies (OSV.dev check)
  • K8s 1.36 changelog reviewed — no breaking changes affect this repo

Informational notes

  • sets.NewString usage in aws.go and openstack_test.go is deprecated but still compiles (pre-existing)
  • NewSimpleClientset in test files is deprecated but still compiles (pre-existing)

All commits carry Assisted-by: Claude Code trailers.

@dfarrell07
Rebase k8s-rebase-1.36.2 to k8s 1.36
82db468 
go get k8s.io/api@v0.36.2
go get k8s.io/apiextensions-apiserver@v0.36.2
go get k8s.io/apimachinery@v0.36.2
go get k8s.io/apiserver@v0.36.2
go get k8s.io/client-go@v0.36.2
go get k8s.io/cloud-provider@v0.36.2
go get k8s.io/component-base@v0.36.2
go get sigs.k8s.io/controller-runtime@v0.24.1
go get github.com/openshift/api
go get github.com/openshift/client-go
go get github.com/openshift/library-go
go get k8s.io/klog/v2
go get k8s.io/kube-aggregator
go get k8s.io/kube-openapi
go get k8s.io/utils
go get sigs.k8s.io/json
go get sigs.k8s.io/kube-storage-version-migrator
go get sigs.k8s.io/randfill
go get sigs.k8s.io/structured-merge-diff/v6
go get sigs.k8s.io/yaml
go mod tidy

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Assisted-by: Claude Code <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 871b3d98-e914-4541-a118-c4c32059b89e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2026
@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dfarrell07
Once this PR has been reviewed and has the lgtm label, please assign martinkennelly for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dfarrell07 dfarrell07 closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dfarrell07