[release-5.0] OCPBUGS-120694: Installed Operators page fails with catalogsources "forbidden ... at the cluster scope" error - #17142
Conversation
OCPBUGS-111081 When the Firehose component was replaced by hooks in MultiListPage (CONSOLE-5026), the loadError computation lost the check that excluded resources declared with optional: true from contributing to the page's fatal error. This caused the Installed Operators page to show a "catalogsources forbidden" error for users whose RBAC is delivered via namespace-scoped RoleBindings only, since the cluster-scoped CatalogSource fetch (declared optional) would fail and its error would be promoted to a fatal page error. The fix cross-references each watched resource's key against the watchResources input config to check the optional flag, restoring the 4.21 behavior where optional resource errors are silently tolerated. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
OCPBUGS-111081 Fix Prettier formatting violation in loadError useMemo (single-line condition). Revert MAX_WARNINGS from 343 back to 342 since this PR does not change the ESLint warning count.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@platex-rehor-bot: This pull request references Jira Issue OCPBUGS-120694, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: platex-rehor-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @platex-rehor-bot. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/jira refresh |
|
@platex-rehor-bot: This pull request references Jira Issue OCPBUGS-120694, which is valid. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/ok-to-test |
|
/retest |
|
@platex-rehor-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Bug
OCPBUGS-120694
Backport of OCPBUGS-111081 to release-5.0.
Original fix: #17072
Changes
Cherry-picked from main (2 commits).
/jira cherrypick OCPBUGS-120694