chore(deps): update go-github to v90 - #159
Open
dsimansk wants to merge 1 commit into
Open
Conversation
openshift-ci
Bot
added
the
do-not-merge/hold
dsimansk
force-pushed
the
srvocf-1053-go-github-v90
branch
from
August 24, 2026 16:03
12276db to
a2d5084
Compare
openshift-ci
Bot
added
the
needs-rebase
Bump github.com/google/go-github from v72 to v90. The v90 major release replaces the fluent client constructor with functional options and changes several method signatures. Adapt the GitHub SCM client accordingly: - build the client via NewClient(WithHTTPClient, WithAuthToken, WithURLs) instead of NewClient(...).WithAuthToken(...) and a settable BaseURL field - pass Commit and Blob by value to CreateCommit and CreateBlob - call UpdateRef with the ref string and an UpdateRef body - call CreateOrUpdateRepoSecret with the secret name and a SecretRequest body Add a branchRef helper so the GetRef and UpdateRef call sites share one ref string; go-github provides no such helper. Issue SRVOCF-1053 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dsimansk
force-pushed
the
srvocf-1053-go-github-v90
branch
from
August 24, 2026 16:05
a2d5084 to
c18df08
Compare
Author
|
/test e2e-aws |
openshift-ci
Bot
removed
the
needs-rebase
|
@dsimansk: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmeida The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump github.com/google/go-github from v72 to v90.
The v90 major release replaces the fluent client constructor with functional options and changes several method signatures. Adapt the GitHub SCM client accordingly:
Add a branchRef helper so the GetRef and UpdateRef call sites share one ref string; go-github provides no such helper.
Summary
Fixes SRVOCF-1053
/hold