PF5: OLS-4155: Await route registration in query/feedback test intercepts

[kyoto]

Summary by CodeRabbit

• Tests
  • Updated end-to-end test synchronization for query and feedback interception.
  • Improved test handling across feedback, events, logs, and attachment scenarios.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 082dfb1d-d1dd-4268-951d-32418d1de51b

📥 Commits

Reviewing files that changed from the base of the PR and between a3ff5ac and b9383f0.

📒 Files selected for processing (2)

• tests/support/fixtures.ts
• tests/tests/lightspeed.spec.ts

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

---

📝 Walkthrough

Walkthrough

The interception helpers now return objects with a received completion promise. Lightspeed end-to-end tests use this property when waiting for query and feedback requests.

Changes

Interceptor completion signals

Layer / File(s)	Summary
Update interceptor return contracts tests/support/fixtures.ts	interceptQuery and interceptFeedback return their completion promises under received.
Migrate Lightspeed interception waits tests/tests/lightspeed.spec.ts	Affected tests store interceptor results and await received for feedback, events, logs, and ACM attachment scenarios.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b9383

This change makes Lightspeed end-to-end tests wait for registered query and feedback interception completion, reducing timing-related test flakiness. No merge-blocking risk is currently identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly describes the main change: awaiting route registration in query and feedback test intercepts.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@kyoto: This pull request references OLS-4155 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment