Skip to content

OLS-3548 Regenerate bundle for temperatureSupported - #2018

Open
xrajesh wants to merge 1 commit into
openshift:mainfrom
xrajesh:OLS-3548-temperature-supported-bundle
Open

OLS-3548 Regenerate bundle for temperatureSupported#2018
xrajesh wants to merge 1 commit into
openshift:mainfrom
xrajesh:OLS-3548-temperature-supported-bundle

Conversation

@xrajesh

@xrajesh xrajesh commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Depends on #1993 and should be merged after it.

This PR contains only the generated bundle manifest updates for temperatureSupported, split out so #1993 can run/pass the operator tests first.

Summary by CodeRabbit

  • Documentation
    • Documented the model temperature support setting.
    • Clarified that leaving the setting unset defaults to supported, while disabling it applies to models that reject temperature parameters.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c6964663-b7a0-42f2-a7bd-d7bfe189ac2f

📥 Commits

Reviewing files that changed from the base of the PR and between aa7e4de and 96b6ec6.

⛔ Files ignored due to path filters (1)
  • bundle/manifests/ols.openshift.io_olsconfigs.yaml is excluded by !bundle/manifests/ols.openshift.io_olsconfigs.yaml
📒 Files selected for processing (1)
  • bundle/manifests/lightspeed-operator.clusterserviceversion.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

The CSV spec now describes the temperatureSupported model parameter. It states that an unset value means temperature is supported and that false applies to models that reject temperature.

Changes

Model Parameter Documentation

Layer / File(s) Summary
Temperature support descriptor
bundle/manifests/lightspeed-operator.clusterserviceversion.yaml
Adds the display name and behavior description for temperatureSupported.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 96b6e

This updates the bundle descriptor documentation for temperature support behavior. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the bundle regeneration for the temperatureSupported parameter, which matches the pull request changes and objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@xrajesh
xrajesh force-pushed the OLS-3548-temperature-supported-bundle branch from 4be5e05 to 96b6ec6 Compare September 4, 2026 03:07
@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshuawilson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant