Skip to content

[release-4.22] SPLAT-2865: Added multi vCenter Day 2 Support - #1531

Open
vr4manta wants to merge 8 commits into
openshift:release-4.22from
vr4manta:SPLAT-2865
Open

[release-4.22] SPLAT-2865: Added multi vCenter Day 2 Support#1531
vr4manta wants to merge 8 commits into
openshift:release-4.22from
vr4manta:SPLAT-2865

Conversation

@vr4manta

@vr4manta vr4manta commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

SPLAT-2865

Changes

  • Changed operator to load cloud config from openshift-config-managed
  • Added logic to add new VAP for validating infrastructure (FD) removals against current CPMS and machines
  • Created E2Es for new vSphere VAP

Notes:
This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 6, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 6, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Contributor

@vr4manta: This pull request references SPLAT-2865 which is a valid jira issue.

Details

In response to this:

SPLAT-2865

Changes

  • Added logic to add new VAP for validating infrastructure (FD) removals against current CPMS and machines
  • Created E2Es for new vSphere VAP

Notes:
This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4de11b02-0192-4b50-9a17-7773bc2643ba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign racheljpg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vr4manta vr4manta mentioned this pull request Aug 6, 2026
Open
@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@vr4manta vr4manta changed the title WIP: [release-4.22] SPLAT-2865: Added new VAP for vSphere infra validation against current cpms and machines WIP: [release-4.22] SPLAT-2865: Added multi vCenter Day 2 Support Aug 10, 2026
@vr4manta
SPLAT-2826: Compare against oldObject in vSphere failure-domain VAPs
8fbe4e7 
The Machine and MachineSet VAPs only checked whether a region/zone
label pair existed in the incoming Infrastructure spec, so a Machine
or MachineSet whose labels never matched any failure domain — old or
new — caused every Infrastructure update to be denied. Add an oldFds
variable sourced from oldObject and only deny when a failure domain
existed in the old spec and was removed from the new one.

(cherry picked from commit 4ef0ad1)
@vr4manta vr4manta changed the title WIP: [release-4.22] SPLAT-2865: Added multi vCenter Day 2 Support [release-4.22] SPLAT-2865: Added multi vCenter Day 2 Support Sep 4, 2026
@vr4manta
vr4manta marked this pull request as ready for review September 4, 2026 11:30
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2026
@openshift-ci
openshift-ci Bot requested review from mdbooth and racheljpg September 4, 2026 11:30
@vr4manta

vr4manta commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/pipeline required

@openshift-merge-bot

openshift-merge-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-virtualmedia

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d51e210-a858-11f1-8021-2ae6565127f3-0

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb9027b0-a873-11f1-9d70-57471176ae00-0

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-virtualmedia 8fbe4e7 link true /test e2e-metal-ipi-virtualmedia

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdbooth mdbooth Awaiting requested review from mdbooth
@racheljpg racheljpg Awaiting requested review from racheljpg

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vr4manta @openshift-ci-robot