OCPBUGS-104214: Fix etcd restore intro on node recreation

[Pratik-Redhat-Tech]

Summary

Since OpenShift 4.18, the standard multi-node etcd restore uses disable-etcd.sh on control plane nodes and cluster-restore.sh on the recovery host. Recreating two control plane nodes is optional, not required.

The intro to "Restoring a cluster manually from an etcd backup" still said the standard restore required complete recreation of 2 control plane nodes. That contradicts the current procedure and can mislead UPI users.

This updates that intro so it matches the 4.18+ restore flow.

Fixes https://issues.redhat.com/browse/OCPBUGS-104214

Test plan

• Confirm modules/manually-restoring-cluster-etcd-backup.adoc no longer says the standard restore requires recreating 2 control plane nodes
• Confirm it states that recreating non-recovery control plane machines is optional
• Confirm it still describes the manual restore as starting a three-member etcd cluster on existing nodes

[openshift-ci-robot]

@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-104214, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Since OpenShift 4.18, the standard multi-node etcd restore uses disable-etcd.sh on control plane nodes and cluster-restore.sh on the recovery host. Recreating two control plane nodes is optional, not required.

The intro to "Restoring a cluster manually from an etcd backup" still said the standard restore required complete recreation of 2 control plane nodes. That contradicts the current procedure and can mislead UPI users.

This updates that intro so it matches the 4.18+ restore flow.

Fixes https://issues.redhat.com/browse/OCPBUGS-104214

Test plan

• Confirm modules/manually-restoring-cluster-etcd-backup.adoc no longer says the standard restore requires recreating 2 control plane nodes
• Confirm it states that recreating non-recovery control plane machines is optional
• Confirm it still describes the manual restore as starting a three-member etcd cluster on existing nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @Pratik-Redhat-Tech. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.