OCPBUGS-114346: Document OIDC IdP naming restriction for group sync - #119013
OCPBUGS-114346: Document OIDC IdP naming restriction for group sync#119013agawai wants to merge 1 commit into
Conversation
When openID.claims.groups is set, oauth-server writes oauth.openshift.io/idp.<name> on Group objects. Kubernetes annotation keys cannot contain spaces, so names such as AIF - Keycloak fail login. Document the restriction, the recommended naming, and the redirect URL update if the IdP is renamed. Signed-off-by: Akanksha Gawai <280726545+agawai@users.noreply.github.com>
|
@agawai: This pull request references Jira Issue OCPBUGS-114346, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @agawai. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes OCPBUGS-114346
When
openID.claims.groupsis configured, oauth-server annotates synchronizedGroupobjects withoauth.openshift.io/idp.<IdP name>. Kubernetes annotation keys cannot contain spaces, so identity provider names such asAIF - KeycloakorMicrosoft Entra IDfail login withAn authentication error occurred.This change documents that restriction on the OpenID Connect identity provider page, recommends a name such as
AIF-Keycloak, and notes that the OIDC client redirect URL must be updated if the IdP is renamed.The product defect is tracked in OCPBUGS-56908 (oauth-server PR 252). This docs PR covers current shipped behavior (including 4.20/4.21) until that fix is available.
Test plan
modules/identity-provider-oidc-about.adoc(included by Configuring an OpenID Connect identity provider)nameandgroupscallouts in the sample CRs mention the restrictionMade with Cursor