Skip to content

[release-4.20] OCPBUGS-114440: Fix probe termination test to use pod status instead of kubelet event text - #31570

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.20from
openshift-cherrypick-robot:cherry-pick-31528-to-release-4.20
Open

[release-4.20] OCPBUGS-114440: Fix probe termination test to use pod status instead of kubelet event text#31570
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.20from
openshift-cherrypick-robot:cherry-pick-31528-to-release-4.20

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #31528

/assign Chandan9112

…of kubelet event text

The [sig-node] Probe configuration terminationGracePeriodSeconds tests
matched a hardcoded substring ("Container started") against the
kubelet "Started" event message to detect container restarts. That
message text differs across kubelet versions: release-4.20/4.21 emit
"Started container %v" while 4.22/main emit "Container started".
The substring match only succeeds with the newer wording, so the test
timed out deterministically on 4.20/4.21 with "context deadline
exceeded" while appearing to pass most of the time on 4.22/main.

Replace the event-message matching with pod.Status.ContainerStatuses:
the container's RestartCount gates on the first restart cycle, and
Running.StartedAt (paired with the "Killing" event's FirstTimestamp)
gives the restart and kill-decision timestamps directly from the API
instead of parsing free-text event messages. This is stable across
kubelet versions and platforms.

Also removes CalculateEventTimeDiff from node_utils.go, which was
only used by the old event-matching logic and has no other callers.

Verified on a live 4.20 cluster: all three tests now pass with
accurate measurements (11s, 10s, and 60s against expected 10s, 10s,
and 60s grace periods).
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ca4bbf40-b31f-4840-a717-ecbf9fe6aa84

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from mrunalp and p0lyn0mial August 27, 2026 09:53
@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue OCPBUGS-111581 has been cloned as Jira Issue OCPBUGS-114440. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-114440: Fix probe termination test to use pod status instead of kubelet event text

Details

In response to this:

This is an automated cherry-pick of #31528

/assign Chandan9112

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.20] OCPBUGS-111581: Fix probe termination test to use pod status instead of kubelet event text [release-4.20] OCPBUGS-114440: Fix probe termination test to use pod status instead of kubelet event text Aug 27, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 27, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-114440, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-111581 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-111581 to target a version in 4.21.0, 4.21.z, but it targets "5.1.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #31528

/assign Chandan9112

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Chandan9112

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 27, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Chandan9112: This pull request references Jira Issue OCPBUGS-114440, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-111581 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-111581 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (cmaurya@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Chandan9112

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@Chandan9112: This pull request references Jira Issue OCPBUGS-114440, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-111581 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-111581 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (cmaurya@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Chandan9112

Copy link
Copy Markdown
Contributor

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 27, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Chandan9112: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Automated triage: This failure appears unrelated to the PR changes.

Rationale: The job failed in the baremetalds-devscripts-setup pre-step while downloading Go 1.24.10 from https://go.dev/dl/go1.24.10.linux-amd64.tar.gz; the download ended with The read operation timed out and exit status 2 before the e2e test phase began. PR #31570 changes only sig-node probe termination test helpers.

Evidence:

  • The failing step was e2e-metal-ipi-ovn-ipv6-baremetalds-devscripts-setup; the log reports failed to create temporary content file: The read operation timed out.
  • The job log states Step phase pre failed, so no e2e tests ran in this job.
  • The PR changes test/extended/node/node_e2e/probe_termination.go and test/extended/node/node_utils.go, with no setup, Go-download, or metal infrastructure changes.
  • 14 of 17 PR checks passed, including unit, lint, verify, and multiple other e2e jobs.
  • No overlapping build10 outage was reported for the job window.

If you disagree with this assessment, /retest ci/prow/e2e-metal-ipi-ovn-ipv6 to re-run the job.


AI-generated. Review for accuracy.

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

/override ci/prow/e2e-aws-ovn-fips

Automated triage: This failure appears unrelated to the PR changes.

Rationale: PR #31570 changes only the sig-node probe termination test and node test helpers. The AWS FIPS run completed the e2e suite and reported one blocking failure in the unrelated sig-storage local dir-bindmounted volume test; all three PR-targeted [sig-node] Probe configuration terminationGracePeriod tests passed.

Evidence:

  • The run summary was 1 blocking fail, 0 informing fail, 1752 pass, 1898 skip; the sole failure was [sig-storage] ... [LocalVolumeType: dir-bindmounted] ... volumes should store data.
  • The PR changes test/extended/node/node_e2e/probe_termination.go and test/extended/node/node_utils.go; it does not change storage code or configuration.
  • 14 of 17 PR checks passed, including unit, lint, verify, and multiple other e2e jobs.
  • No overlapping build01 outage was reported for the job window.

If you disagree with this assessment, /retest ci/prow/e2e-aws-ovn-fips to re-run the job.


AI-generated. Review for accuracy.

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: Overrode contexts on behalf of redhat-chai-bot: ci/prow/e2e-aws-ovn-fips

Details

In response to this:

/override ci/prow/e2e-aws-ovn-fips

Automated triage: This failure appears unrelated to the PR changes.

Rationale: PR #31570 changes only the sig-node probe termination test and node test helpers. The AWS FIPS run completed the e2e suite and reported one blocking failure in the unrelated sig-storage local dir-bindmounted volume test; all three PR-targeted [sig-node] Probe configuration terminationGracePeriod tests passed.

Evidence:

  • The run summary was 1 blocking fail, 0 informing fail, 1752 pass, 1898 skip; the sole failure was [sig-storage] ... [LocalVolumeType: dir-bindmounted] ... volumes should store data.
  • The PR changes test/extended/node/node_e2e/probe_termination.go and test/extended/node/node_utils.go; it does not change storage code or configuration.
  • 14 of 17 PR checks passed, including unit, lint, verify, and multiple other e2e jobs.
  • No overlapping build01 outage was reported for the job window.

If you disagree with this assessment, /retest ci/prow/e2e-aws-ovn-fips to re-run the job.


AI-generated. Review for accuracy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: Overrode contexts on behalf of redhat-chai-bot: ci/prow/e2e-metal-ipi-ovn-ipv6

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Automated triage: This failure appears unrelated to the PR changes.

Rationale: The job failed in the baremetalds-devscripts-setup pre-step while downloading Go 1.24.10 from https://go.dev/dl/go1.24.10.linux-amd64.tar.gz; the download ended with The read operation timed out and exit status 2 before the e2e test phase began. PR #31570 changes only sig-node probe termination test helpers.

Evidence:

  • The failing step was e2e-metal-ipi-ovn-ipv6-baremetalds-devscripts-setup; the log reports failed to create temporary content file: The read operation timed out.
  • The job log states Step phase pre failed, so no e2e tests ran in this job.
  • The PR changes test/extended/node/node_e2e/probe_termination.go and test/extended/node/node_utils.go, with no setup, Go-download, or metal infrastructure changes.
  • 14 of 17 PR checks passed, including unit, lint, verify, and multiple other e2e jobs.
  • No overlapping build10 outage was reported for the job window.

If you disagree with this assessment, /retest ci/prow/e2e-metal-ipi-ovn-ipv6 to re-run the job.


AI-generated. Review for accuracy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-fips ef25bcf link true /test e2e-aws-ovn-fips
ci/prow/e2e-metal-ipi-ovn-ipv6 ef25bcf link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants