[release-5.0] TRT-2930: skip regional-PD e2e on GCP families without pd-standard - #31575
Conversation
[sig-storage][Jira:"Storage"][Driver: pd.csi.storage.gke.io] "regional PD should store data and sync across zones" provisions a regional pd-standard PersistentDisk and attaches it to the worker that runs the test pod. Several GCP families cannot attach pd-standard - C4/C4A/C4D and N4 are Hyperdisk-only, and C3/C3D support only pd-ssd/pd-balanced - so the attach fails deterministically: AttachVolume.Attach failed: googleapi: Error 400: Regional disks is not supported for n4-standard-8 machine type The test already guarded the cross-zone reattach against such a control plane, but not the primary pod's worker, so it still failed hard on N4 workers. Skip the whole test in BeforeEach when the workers use a family without pd-standard; on pd-standard-capable workers (e.g. N2) it runs unchanged. The machine-family check is consolidated into a single anyNodeLacksPDStandard helper (shared by the worker and control-plane guards) backed by familyLacksPDStandard / nodeInstanceType, and the family list now includes c4d. Adds table-driven and fake-clientset unit tests for the new helpers. This lets the GCP jobs that run openshift/conformance/parallel move to N4 without the temporary per-job TEST_SKIPS added in openshift/release. It should be backported to release-5.1, release-5.0 and release-4.23 (the branches that carry this test). Lineage: test added in STOR-3063. Assisted-By: Claude Opus 4.8
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: TRT-2930 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
ready-for-human-review
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Scheduling required tests: |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
This is an automated cherry-pick of #31572
/assign stbenjam