Skip to content

[release-4.23] TRT-2930: skip regional-PD e2e on GCP families without pd-standard - #31576

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.23from
openshift-cherrypick-robot:cherry-pick-31572-to-release-4.23
Open

[release-4.23] TRT-2930: skip regional-PD e2e on GCP families without pd-standard#31576
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.23from
openshift-cherrypick-robot:cherry-pick-31572-to-release-4.23

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #31572

/assign stbenjam

[sig-storage][Jira:"Storage"][Driver: pd.csi.storage.gke.io] "regional PD
should store data and sync across zones" provisions a regional pd-standard
PersistentDisk and attaches it to the worker that runs the test pod. Several
GCP families cannot attach pd-standard - C4/C4A/C4D and N4 are Hyperdisk-only,
and C3/C3D support only pd-ssd/pd-balanced - so the attach fails
deterministically:

  AttachVolume.Attach failed: googleapi: Error 400:
  Regional disks is not supported for n4-standard-8 machine type

The test already guarded the cross-zone reattach against such a control
plane, but not the primary pod's worker, so it still failed hard on N4
workers. Skip the whole test in BeforeEach when the workers use a family
without pd-standard; on pd-standard-capable workers (e.g. N2) it runs
unchanged.

The machine-family check is consolidated into a single anyNodeLacksPDStandard
helper (shared by the worker and control-plane guards) backed by
familyLacksPDStandard / nodeInstanceType, and the family list now includes
c4d. Adds table-driven and fake-clientset unit tests for the new helpers.

This lets the GCP jobs that run openshift/conformance/parallel move to N4
without the temporary per-job TEST_SKIPS added in openshift/release. It
should be backported to release-5.1, release-5.0 and release-4.23 (the
branches that carry this test). Lineage: test added in STOR-3063.

Assisted-By: Claude Opus 4.8
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot

openshift-ci-robot commented Aug 28, 2026

Copy link
Copy Markdown

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: TRT-2930

Details

In response to this:

This is an automated cherry-pick of #31572

/assign stbenjam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Aug 28, 2026
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 45f0a4d2-e2c1-4f5d-b976-b9d33bb1cb39

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jsafrane and tsmetana August 28, 2026 00:47
@openshift-ci

openshift-ci Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign dobsonj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

/override ci/prow/e2e-aws-ovn-serial-1of2

Automated triage: This failure appears unrelated to the PR changes.

Rationale: The job failed before cluster provisioning or e2e execution while building the tools-openstack cache image. The build attempted to reach the CI-internal base-openstack-4-22.ocp.svc service and timed out with curl exit 28. PR #31576 changes only the GCP regional Persistent Disk storage test and its unit tests, with no overlap with the image-build or yum-repository path.

Evidence:

  • ci/prow/verify, ci/prow/lint, ci/prow/verify-deps, ci/prow/go-verify-deps, ci/prow/unit, and ci/prow/images passed.
  • The job ended with executing_graph:step_failed:building_cache_image and DockerBuildFailed; no cluster was provisioned and no e2e tests ran.
  • The failing request was curl http://base-openstack-4-22.ocp.svc ..., which timed out after receiving 0 bytes.

If you disagree with this assessment, /retest ci/prow/e2e-aws-ovn-serial-1of2 to re-run the job.


AI-generated. Review for accuracy.

@openshift-ci

openshift-ci Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: Overrode contexts on behalf of redhat-chai-bot: ci/prow/e2e-aws-ovn-serial-1of2

Details

In response to this:

/override ci/prow/e2e-aws-ovn-serial-1of2

Automated triage: This failure appears unrelated to the PR changes.

Rationale: The job failed before cluster provisioning or e2e execution while building the tools-openstack cache image. The build attempted to reach the CI-internal base-openstack-4-22.ocp.svc service and timed out with curl exit 28. PR #31576 changes only the GCP regional Persistent Disk storage test and its unit tests, with no overlap with the image-build or yum-repository path.

Evidence:

  • ci/prow/verify, ci/prow/lint, ci/prow/verify-deps, ci/prow/go-verify-deps, ci/prow/unit, and ci/prow/images passed.
  • The job ended with executing_graph:step_failed:building_cache_image and DockerBuildFailed; no cluster was provisioned and no e2e tests ran.
  • The failing request was curl http://base-openstack-4-22.ocp.svc ..., which timed out after receiving 0 bytes.

If you disagree with this assessment, /retest ci/prow/e2e-aws-ovn-serial-1of2 to re-run the job.


AI-generated. Review for accuracy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

/override ci/prow/e2e-gcp-ovn-upgrade

Automated triage: This failure appears unrelated to the PR changes.

Rationale: The job completed the GCP OVN upgrade workflow and failed one independent [sig-ci] [Early] invariant: test/extended/ci/job_names.go:323 reported MCP worker uses rhel-10 as stream but was expecting rhel-9. PR #31576 changes only test/extended/storage/gce_pd_regional.go and test/extended/storage/gce_pd_regional_test.go; it does not modify the job-name invariant or OS-stream configuration.

Evidence:

  • The target job had 32 passing tests, 2 skipped tests, and 0 flaky tests; the only blocking failure was prow job name should match os version.
  • The job definition is the release-4.23 GCP presubmit using the openshift-upgrade-gcp workflow; the failure is outside the regional-PD test area.
  • ci/prow/unit, ci/prow/lint, ci/prow/verify, ci/prow/verify-deps, ci/prow/go-verify-deps, and ci/prow/images passed.

If you disagree with this assessment, /retest ci/prow/e2e-gcp-ovn-upgrade to re-run the job.


AI-generated. Review for accuracy.


AI-generated. Review for accuracy.

@openshift-ci

openshift-ci Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: Overrode contexts on behalf of redhat-chai-bot: ci/prow/e2e-gcp-ovn-upgrade

Details

In response to this:

/override ci/prow/e2e-gcp-ovn-upgrade

Automated triage: This failure appears unrelated to the PR changes.

Rationale: The job completed the GCP OVN upgrade workflow and failed one independent [sig-ci] [Early] invariant: test/extended/ci/job_names.go:323 reported MCP worker uses rhel-10 as stream but was expecting rhel-9. PR #31576 changes only test/extended/storage/gce_pd_regional.go and test/extended/storage/gce_pd_regional_test.go; it does not modify the job-name invariant or OS-stream configuration.

Evidence:

  • The target job had 32 passing tests, 2 skipped tests, and 0 flaky tests; the only blocking failure was prow job name should match os version.
  • The job definition is the release-4.23 GCP presubmit using the openshift-upgrade-gcp workflow; the failure is outside the regional-PD test area.
  • ci/prow/unit, ci/prow/lint, ci/prow/verify, ci/prow/verify-deps, ci/prow/go-verify-deps, and ci/prow/images passed.

If you disagree with this assessment, /retest ci/prow/e2e-gcp-ovn-upgrade to re-run the job.


AI-generated. Review for accuracy.


AI-generated. Review for accuracy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

/override ci/prow/e2e-vsphere-ovn

Automated triage: This failure appears unrelated to the PR changes.

Rationale: PR #31576 changes only GCP regional Persistent Disk storage skip logic/tests. The vSphere run correctly skipped the GCP-only test; its blocking failures were an RHEL stream expectation mismatch and an etcd request timeout in a network service test. The informing failures were also unrelated (node-count and empty image-reference conditions).

Evidence:

  • The run recorded 2342 passing tests, 2 blocking failures, and 2 informing failures; no gce_pd_regional_test.go reference appeared.
  • ci/prow/e2e-gcp-csi passed, while the failing vSphere run used the openshift-e2e-vsphere workflow.
  • The blocking failures originated in test/extended/ci/job_names.go and Kubernetes network service testing, not the changed storage files.

If you disagree with this assessment, /retest ci/prow/e2e-vsphere-ovn to re-run the job.


AI-generated. Review for accuracy.

@openshift-ci

openshift-ci Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: Overrode contexts on behalf of redhat-chai-bot: ci/prow/e2e-vsphere-ovn

Details

In response to this:

/override ci/prow/e2e-vsphere-ovn

Automated triage: This failure appears unrelated to the PR changes.

Rationale: PR #31576 changes only GCP regional Persistent Disk storage skip logic/tests. The vSphere run correctly skipped the GCP-only test; its blocking failures were an RHEL stream expectation mismatch and an etcd request timeout in a network service test. The informing failures were also unrelated (node-count and empty image-reference conditions).

Evidence:

  • The run recorded 2342 passing tests, 2 blocking failures, and 2 informing failures; no gce_pd_regional_test.go reference appeared.
  • ci/prow/e2e-gcp-csi passed, while the failing vSphere run used the openshift-e2e-vsphere workflow.
  • The blocking failures originated in test/extended/ci/job_names.go and Kubernetes network service testing, not the changed storage files.

If you disagree with this assessment, /retest ci/prow/e2e-vsphere-ovn to re-run the job.


AI-generated. Review for accuracy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

/override ci/prow/e2e-gcp-ovn

Automated triage: This failure appears unrelated to the PR changes.

Rationale: The only blocking failure in this GCP run is the generic [sig-ci] [Early] prow job name should match os version check, which failed because MCP master uses rhel-10 as stream but was expecting rhel-9. The PR changes only the GCP regional-PD storage test and its unit tests; they do not modify job-name validation, release metadata, or cluster OS selection.

Evidence:

  • The GCP run completed the conformance suite with 2321 pass, 1 blocking fail, and 2 informing fail; the blocking failure is the OS-stream assertion above.
  • The PR's ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn-upgrade, and ci/prow/e2e-vsphere-ovn checks passed, as did unit, lint, verify, and dependency checks.
  • The run reached the test phase and completed post-test collection and deprovisioning successfully; no build04 outage overlapped the run window.

If you disagree with this assessment, /retest ci/prow/e2e-gcp-ovn to re-run the job.


AI-generated. Review for accuracy.

@openshift-ci

openshift-ci Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: Overrode contexts on behalf of redhat-chai-bot: ci/prow/e2e-gcp-ovn

Details

In response to this:

/override ci/prow/e2e-gcp-ovn

Automated triage: This failure appears unrelated to the PR changes.

Rationale: The only blocking failure in this GCP run is the generic [sig-ci] [Early] prow job name should match os version check, which failed because MCP master uses rhel-10 as stream but was expecting rhel-9. The PR changes only the GCP regional-PD storage test and its unit tests; they do not modify job-name validation, release metadata, or cluster OS selection.

Evidence:

  • The GCP run completed the conformance suite with 2321 pass, 1 blocking fail, and 2 informing fail; the blocking failure is the OS-stream assertion above.
  • The PR's ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn-upgrade, and ci/prow/e2e-vsphere-ovn checks passed, as did unit, lint, verify, and dependency checks.
  • The run reached the test phase and completed post-test collection and deprovisioning successfully; no build04 outage overlapped the run window.

If you disagree with this assessment, /retest ci/prow/e2e-gcp-ovn to re-run the job.


AI-generated. Review for accuracy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

/override ci/prow/e2e-aws-ovn-serial-2of2

Automated triage: This failure appears unrelated to the PR changes.

Rationale: The job reached the test suite and failed a sig-ci metadata check because the cluster reported rhel-10 while the test expected rhel-9. PR #31576 changes GCP regional Persistent Disk storage handling and its unit tests; it does not change the job-name/version validation or AWS job configuration.

Evidence:

  • The failing job recorded 156 passing tests, 238 skips, and exactly 1 blocking failure: prow job name should match os version.
  • The direct failure is test/extended/ci/job_names.go:323: MCP master uses rhel-10 as stream but was expecting rhel-9.
  • The PR changes only test/extended/storage/gce_pd_regional.go and test/extended/storage/gce_pd_regional_test.go; GCP CSI, GCP OVN, AWS OVN serial 1of2, and vSphere OVN checks passed.

If you disagree with this assessment, /retest ci/prow/e2e-aws-ovn-serial-2of2 to re-run the job.


AI-generated. Review for accuracy.

@openshift-ci

openshift-ci Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: Overrode contexts on behalf of redhat-chai-bot: ci/prow/e2e-aws-ovn-serial-2of2

Details

In response to this:

/override ci/prow/e2e-aws-ovn-serial-2of2

Automated triage: This failure appears unrelated to the PR changes.

Rationale: The job reached the test suite and failed a sig-ci metadata check because the cluster reported rhel-10 while the test expected rhel-9. PR #31576 changes GCP regional Persistent Disk storage handling and its unit tests; it does not change the job-name/version validation or AWS job configuration.

Evidence:

  • The failing job recorded 156 passing tests, 238 skips, and exactly 1 blocking failure: prow job name should match os version.
  • The direct failure is test/extended/ci/job_names.go:323: MCP master uses rhel-10 as stream but was expecting rhel-9.
  • The PR changes only test/extended/storage/gce_pd_regional.go and test/extended/storage/gce_pd_regional_test.go; GCP CSI, GCP OVN, AWS OVN serial 1of2, and vSphere OVN checks passed.

If you disagree with this assessment, /retest ci/prow/e2e-aws-ovn-serial-2of2 to re-run the job.


AI-generated. Review for accuracy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn 848e015 link true /test e2e-vsphere-ovn
ci/prow/e2e-gcp-ovn-upgrade 848e015 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-microshift-serial 848e015 link true /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-aws-ovn-serial-2of2 848e015 link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-aws-ovn-microshift 848e015 link true /test e2e-aws-ovn-microshift
ci/prow/e2e-aws-ovn-fips 848e015 link true /test e2e-aws-ovn-fips
ci/prow/e2e-vsphere-ovn-upi 848e015 link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-aws-ovn-serial-1of2 848e015 link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-aws-csi 848e015 link true /test e2e-aws-csi
ci/prow/e2e-gcp-ovn 848e015 link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants