Skip to content

[Test] Rehearse the doctor job with the fix - #84841

Open
kasturinarra wants to merge 1 commit into
openshift:mainfrom
kasturinarra:rehearse_job_exclusion
Open

[Test] Rehearse the doctor job with the fix#84841
kasturinarra wants to merge 1 commit into
openshift:mainfrom
kasturinarra:rehearse_job_exclusion

Conversation

@kasturinarra

@kasturinarra kasturinarra commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Rehearses the LVM and MicroShift doctor jobs with the OCPEDGE-3050-exclude-disabled-jobs branch of openshift-eng_edge-tooling.
  • Runs both doctor jobs against the cloned repository in /tmp.
  • Updates the MicroShift doctor job to analyze release 5.0 explicitly.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a6cf9b48-e2fa-4514-8981-cc4195961e7f

📥 Commits

Reviewing files that changed from the base of the PR and between 0fdf99d and 1861836.

📒 Files selected for processing (2)
  • ci-operator/step-registry/openshift/edge-tooling/lvms-ci/doctor/openshift-edge-tooling-lvms-ci-doctor-commands.sh
  • ci-operator/step-registry/openshift/edge-tooling/microshift-ci/doctor/openshift-edge-tooling-microshift-ci-doctor-commands.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The LVMs and MicroShift doctor scripts now clone the edge-tooling repository from a specified branch into /tmp. The MicroShift doctor pipeline now analyzes release 5.0.

Changes

Edge tooling doctor pipelines

Layer / File(s) Summary
Temporary edge-tooling checkout
ci-operator/step-registry/openshift/edge-tooling/*/doctor/*-commands.sh
The LVMs and MicroShift scripts clone the edge-tooling repository into /tmp and set EDGE_TOOLING_DIR to the cloned path.
MicroShift release selection
ci-operator/step-registry/openshift/edge-tooling/microshift-ci/doctor/openshift-edge-tooling-microshift-ci-doctor-commands.sh
The doctor pipeline uses release 5.0 instead of RELEASE_VERSIONS.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 18618

The doctor jobs now use a temporary edge-tooling checkout and MicroShift targets release 5.0. No concrete merge-blocking risk remains.

Suggested reviewers: pmtk

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes testing the doctor job with the included fix. It is concise and related to the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The pull request changes only two shell command files. The diff adds repository cloning and changes a release argument to the static value 5.0. It adds no Ginkgo It(), Describe(), `Context…
Test Structure And Quality ✅ Passed PASS: The pull request changes only two Bash doctor-command scripts. The diff adds a repository clone and changes a release argument; it adds no Ginkgo test files, It blocks, assertions, fixtures, or …
Microshift Test Compatibility ✅ Passed The pull request does not add or modify Ginkgo e2e tests. The exact diff contains changes only in two doctor shell scripts: repository cloning and the MicroShift release argument. No It(), Describe(),…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only two shell orchestration scripts. The diff adds repository cloning and changes a doctor pipeline release argument; it adds no Ginkgo tests and introduces no multi-no…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only two Bash doctor-job scripts. The exact diff adds a repository clone and changes the MicroShift analysis release argument to 5.0. It does not add or modify deploym…
Ote Binary Stdout Contract ✅ Passed PASS. The PR changes only two shell command wrappers. The diff adds a repository clone and changes a Python doctor argument; it does not modify an OTE binary or any Go process-level code. The changed …
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only two shell command files. The diff adds repository cloning and changes a release argument. It adds no Ginkgo e2e tests or test code, so the IPv4 and disconnected-net…
No-Weak-Crypto ✅ Passed PASS. The pull request changes only source checkout behavior and the MicroShift release argument. The added lines clone a repository, set EDGE_TOOLING_DIR, and pass --releases "5.0". The complete …
Container-Privileges ✅ Passed The pull request changes only two shell command files. The added commands clone a repository into /tmp and set EDGE_TOOLING_DIR; MicroShift also changes the release argument. The patch adds no `pr…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request adds only a public git clone URL, a branch name, a temporary path, and a fixed release argument. The clone command may appear in existing shell tracing, but it contains no pas…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@kasturinarra: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-eng-edge-tooling-main-lvms-ci-doctor N/A periodic Registry content changed
periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@kasturinarra

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor periodic-ci-openshift-eng-edge-tooling-main-lvms-ci-doctor

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasturinarra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2026
@openshift-ci

openshift-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@kasturinarra: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant