fix: Match real app-cred id field in route plugin - #1242
Merged
Merged
Conversation
Reference-plugin route() and its test/doc callers looked up a
literal `application_credential_id` key inside the payload block.
Real clients send `{"id": ..., "secret": ...}` per the actual
ApplicationCredentialAuth wire shape (PR #1187) - the sibling-key
name only ever existed in this repo's own ADR prose and test
fixtures, never in real traffic, so route-mode plugins configured
to inspect application_credential would silently fall through to
Passthrough for every real request.
Renamed the lookup and every test/doc payload built to match it
(reference-plugin fixture, ADR 0025, contributor auth-plugins doc,
common.rs/create.rs test helpers, auth_plugin_auth.rs,
tests/api auth_plugin.rs) to key on `id` instead.
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
|
🧪 Tempest Identity Compatibility Results (advisory, non-blocking) rust Failed test IDs |
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
Error Metrics
|
|
Bencher Report| Project | keystone |
| Branch | appcred-route-fixture-fix |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| Command_Serde/apply/remove | 📈 view plot 🚷 view threshold | 125,560.00 ns(-50.59%)Baseline: 254,109.69 ns | 1,308,077.51 ns (9.60%) |
| Command_Serde/apply/set | 📈 view plot 🚷 view threshold | 134,770.00 ns(-67.40%)Baseline: 413,374.53 ns | 3,206,573.02 ns (4.20%) |
| Command_Serde/pack/delete | 📈 view plot 🚷 view threshold | 124.41 ns(+5.76%)Baseline: 117.63 ns | 155.08 ns (80.22%) |
| Command_Serde/pack/delete_index | 📈 view plot 🚷 view threshold | 110.11 ns(+4.92%)Baseline: 104.94 ns | 137.50 ns (80.08%) |
| Command_Serde/pack/set | 📈 view plot 🚷 view threshold | 198.82 ns(+4.16%)Baseline: 190.88 ns | 245.85 ns (80.87%) |
| Command_Serde/pack/set_index | 📈 view plot 🚷 view threshold | 109.20 ns(+4.10%)Baseline: 104.90 ns | 137.85 ns (79.21%) |
| Command_Serde/unpack/delete | 📈 view plot 🚷 view threshold | 195.46 ns(+4.17%)Baseline: 187.64 ns | 271.95 ns (71.87%) |
| Command_Serde/unpack/delete_index | 📈 view plot 🚷 view threshold | 168.34 ns(+7.48%)Baseline: 156.63 ns | 221.38 ns (76.04%) |
| Command_Serde/unpack/set | 📈 view plot 🚷 view threshold | 286.59 ns(+8.13%)Baseline: 265.05 ns | 366.32 ns (78.24%) |
| Command_Serde/unpack/set_index | 📈 view plot 🚷 view threshold | 169.76 ns(+10.30%)Baseline: 153.91 ns | 215.29 ns (78.85%) |
| Payload_encryption/pack/remove_cmd | 📈 view plot 🚷 view threshold | 117.72 ns(+5.61%)Baseline: 111.47 ns | 149.85 ns (78.56%) |
| Payload_encryption/pack/set_cmd | 📈 view plot 🚷 view threshold | 197.36 ns(-0.83%)Baseline: 199.00 ns | 266.09 ns (74.17%) |
| Payload_encryption/unpack/remove_cmd | 📈 view plot 🚷 view threshold | 200.30 ns(+2.25%)Baseline: 195.89 ns | 284.67 ns (70.36%) |
| Payload_encryption/unpack/set_cmd | 📈 view plot 🚷 view threshold | 300.59 ns(+9.81%)Baseline: 273.74 ns | 381.83 ns (78.72%) |
| Raft_1Node_Latency/prefix/1node | 📈 view plot 🚷 view threshold | 2,603,500.00 ns(-17.68%)Baseline: 3,162,524.05 ns | 7,998,754.29 ns (32.55%) |
| Raft_1Node_Latency/read/1node | 📈 view plot 🚷 view threshold | 42,429.00 ns(+13.11%)Baseline: 37,512.42 ns | 52,294.33 ns (81.13%) |
| Raft_1Node_Latency/remove/1node | 📈 view plot 🚷 view threshold | 360,530.00 ns(-68.58%)Baseline: 1,147,283.91 ns | 11,473,119.66 ns (3.14%) |
| Raft_1Node_Latency/write/1node | 📈 view plot 🚷 view threshold | 380,820.00 ns(-60.00%)Baseline: 951,943.12 ns | 7,533,582.48 ns (5.05%) |
| build_snapshot/default | 📈 view plot 🚷 view threshold | 110,920.00 ns(-8.89%)Baseline: 121,748.92 ns | 266,673.76 ns (41.59%) |
| fernet token/project | 📈 view plot 🚷 view threshold | 1,446.00 ns(+1.76%)Baseline: 1,421.01 ns | 1,820.85 ns (79.41%) |
| get_data_keyspace | 📈 view plot 🚷 view threshold | 0.31 ns(-0.71%)Baseline: 0.31 ns | 0.39 ns (80.19%) |
| get_db | 📈 view plot 🚷 view threshold | 0.31 ns(-0.94%)Baseline: 0.31 ns | 0.39 ns (79.96%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 144.34 ns(+3.26%)Baseline: 139.78 ns | 181.81 ns (79.39%) |
| get_keyspace | 📈 view plot 🚷 view threshold | 4.51 ns(-20.34%)Baseline: 5.66 ns | 12.38 ns (36.41%) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference-plugin route() and its test/doc callers looked up a
literal
application_credential_idkey inside the payload block.Real clients send
{"id": ..., "secret": ...}per the actualApplicationCredentialAuth wire shape (PR #1187) - the sibling-key
name only ever existed in this repo's own ADR prose and test
fixtures, never in real traffic, so route-mode plugins configured
to inspect application_credential would silently fall through to
Passthrough for every real request.
Renamed the lookup and every test/doc payload built to match it
(reference-plugin fixture, ADR 0025, contributor auth-plugins doc,
common.rs/create.rs test helpers, auth_plugin_auth.rs,
tests/api auth_plugin.rs) to key on
idinstead.Signed-off-by: Artem Goncharov artem.goncharov@gmail.com