Skip to content

[test_operator] Remove redundant HorizonTest parameters - #4071

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
kstrenkova:remove-default-admin-horizontest
Jul 28, 2026
Merged

[test_operator] Remove redundant HorizonTest parameters#4071
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
kstrenkova:remove-default-admin-horizontest

Conversation

@kstrenkova

Copy link
Copy Markdown
Contributor

Parameters adminUsername and adminPassword are being deprecated in the test-operator [1]. Their defaults are also being removed, therefore it is needed to remove them in ci-framework as well.

Parameters projectName, user, and password were never fully working in the test-operator, as the values were hardcoded regardless of what was set in the CR. The effort to remove them is in test-operator PR [2], which needs their removal in ci-framework as well.

[1] openstack-k8s-operators/test-operator#473
[2] openstack-k8s-operators/test-operator#474

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/0ec5a06a0c3f4ad090e3a1b691460ec1

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 56m 54s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 34m 28s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 53m 41s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 32m 53s
✔️ cifmw-multinode-tempest SUCCESS in 1h 53m 05s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 11s
✔️ openstack-k8s-operators-content-provider-bootc SUCCESS in 41m 27s
cifmw-crc-podified-edpm-baremetal-bootc NODE_FAILURE Node(set) request 099-0000151061 failed in 0s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 10s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 38s
✔️ cifmw-molecule-test_operator SUCCESS in 4m 36s

@evallesp

Copy link
Copy Markdown
Contributor

recheck

@imatza-rh

Copy link
Copy Markdown
Contributor

/lgtm
/approve

Parameters adminUsername and adminPassword are being deprecated
in the test-operator [1]. Their defaults are also being removed,
therefore it is needed to remove them in ci-framework as well.

Parameters projectName, user, and password were never fully
working in the test-operator, as the values were hardcoded
regardless of what was set in the CR. The effort to remove them
is in test-operator PR [2], which needs their removal in
ci-framework as well.

[1] openstack-k8s-operators/test-operator#473
[2] openstack-k8s-operators/test-operator#474

Signed-off-by: Katarina Strenkova <kstrenko@redhat.com>
@imatza-rh

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@imatza-rh

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@imatza-rh

Copy link
Copy Markdown
Contributor

@michburk @evallesp hey, can you please review? thanks

@michburk michburk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imatza-rh, michburk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kstrenkova

Copy link
Copy Markdown
Contributor Author

/retest

@kstrenkova

Copy link
Copy Markdown
Contributor Author

/hold

@kstrenkova

Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-merge-bot
openshift-merge-bot Bot merged commit bbfe5bb into openstack-k8s-operators:main Jul 28, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants