Skip to content

chore: Remove remaining llama-stack references - #101

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
lpiwowar:chore/llama-stack-refs
Sep 25, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
lpiwowar:chore/llama-stack-refs

Conversation

@lpiwowar

@lpiwowar lpiwowar commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Remove the remaining llama-stack references. Llama-stack was recently renamed to OGX. Previous renaming was performed in commit ed943f3 ("Support lightspeed-stack v0.7.0"). This commit cleans up the leftover references.

Summary by CodeRabbit

  • Documentation
    • Updated descriptions and sample configuration comments to refer to OGX rather than OGX/llama-stack.
  • Tests
    • Configuration checks now use the OGX assertion in the affected test scenarios.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openstack-k8s-operators/lightspeed-operator/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0f29d22e-7a62-48aa-a053-22a08c56b32d

📥 Commits

Reviewing files that changed from the base of the PR and between ef9652b and 4dd442d.

📒 Files selected for processing (12)
  • api/v1beta1/openstacklightspeed_getters.go
  • api/v1beta1/openstacklightspeed_types.go
  • config/crd/bases/lightspeed.openstack.org_openstacklightspeeds.yaml
  • config/samples/lightspeed_v1beta1_openstacklightspeed.yaml
  • internal/controller/ogx_config.go
  • internal/controller/ogx_config_test.go
  • test/kuttl/common/openstack-lightspeed-instance/assert-pod-ogx-config.yaml
  • test/kuttl/tests/basic-openstack-lightspeed-configuration/05-assert-llama-stack-config.yaml
  • test/kuttl/tests/basic-openstack-lightspeed-configuration/05-assert-ogx-config.yaml
  • test/kuttl/tests/update-openstacklightspeed/05-assert-llama-stack-config.yaml
  • test/kuttl/tests/update-openstacklightspeed/05-assert-ogx-config.yaml
  • test/kuttl/tests/update-openstacklightspeed/10-assert-ogx-config-update.yaml
💤 Files with no reviewable changes (2)
  • test/kuttl/tests/update-openstacklightspeed/05-assert-llama-stack-config.yaml
  • test/kuttl/tests/basic-openstack-lightspeed-configuration/05-assert-llama-stack-config.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

Comments and schema descriptions now identify the container image and customization as OGX rather than OGX/llama-stack. KUTTL test entries remove llama-stack assertion references and point to the OGX configuration assertion.

Changes

OGX terminology and assertions

Layer / File(s) Summary
Update OGX descriptions and test assertions
api/v1beta1/openstacklightspeed_*.go, config/crd/bases/lightspeed.openstack.org_openstacklightspeeds.yaml, config/samples/lightspeed_v1beta1_openstacklightspeed.yaml, test/kuttl/tests/basic-openstack-lightspeed-configuration/*, test/kuttl/tests/update-openstacklightspeed/*
API comments, the CRD description, and the sample comment now refer to OGX. The KUTTL test entries remove llama-stack assertion references and point to the OGX configuration assertion.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: akrog

Merge Risk: ⚪ Minimal · up to 4dd44

This change updates OGX terminology and test paths without changing operator behavior or test assertions. No actionable merge risk is evident from the reviewed diff.

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the remaining llama-stack references and updating them to OGX terminology.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Keep Documentation Current ✅ Passed PASS. The pull request introduces no user-visible behavior, installation, configuration, CRD field, deployment requirement, or workflow logic change. The non-rename diff only updates OGX wording in Go…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@lpiwowar
lpiwowar force-pushed the chore/llama-stack-refs branch 2 times, most recently from 1292d3a to c7957e1 Compare September 24, 2026 09:53
@lpiwowar lpiwowar changed the title chore: Drop remaining llama-stack references (code and docs) chore: Drop remaining llama-stack references Sep 24, 2026
@centosinfra-prod-github-app

Copy link
Copy Markdown

Remove the remaining llama-stack references. Llama-stack was
recently renamed to OGX. Previous renaming was performed in
commit ed943f3 ("Support lightspeed-stack v0.7.0"). This
commit cleans up the leftover references.

Signed-off-by: Lukas Piwowarski <lpiwowar@redhat.com>
@lpiwowar
lpiwowar force-pushed the chore/llama-stack-refs branch from c7957e1 to 4dd442d Compare September 25, 2026 11:24
@lpiwowar lpiwowar changed the title chore: Drop remaining llama-stack references chore: Remove remaining llama-stack references Sep 25, 2026
@lpiwowar
lpiwowar marked this pull request as ready for review September 25, 2026 11:25
@openshift-ci
openshift-ci Bot requested review from Akrog and umago September 25, 2026 11:25
@centosinfra-prod-github-app

Copy link
Copy Markdown

@umago umago left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Let's merge this soon because it might conflict with other PRs later

@openshift-ci

openshift-ci Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpiwowar, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 3d33171 into openstack-k8s-operators:main Sep 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants