Skip to content

Use ECDSA P-256 private keys for cert-manager certificates #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fmount wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use ECDSA P-256 private keys for cert-manager certificates #1973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bindata/operator/infra-operator-webhooks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ spec:
issuerRef:
kind: Issuer
name: infra-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256

@bshephar bshephar Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

256 is the default for ECDSA it seems:
https://github.com/cert-manager/cert-manager/blob/master/internal/apis/certmanager/types_certificate.go#L311-L319

Probably don't need to explicitly set the size. But, weird that they would default to RSA in 2026. I guess you could also set the size and not the algorithm too. But it's not a problem, just providing the feedback since I went to the trouble of looking up the defaults.

secretName: infra-operator-webhook-server-cert
---
apiVersion: admissionregistration.k8s.io/v1
Expand Down
3 changes: 3 additions & 0 deletions bindata/operator/openstack-baremetal-operator-webhooks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ spec:
issuerRef:
kind: Issuer
name: openstack-baremetal-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: openstack-baremetal-operator-webhook-server-cert
---
apiVersion: admissionregistration.k8s.io/v1
Expand Down
6 changes: 6 additions & 0 deletions bindata/operator/operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,9 @@ spec:
issuerRef:
kind: Issuer
name: openstack-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: metrics-server-cert
---
apiVersion: cert-manager.io/v1
Expand All @@ -174,6 +177,9 @@ spec:
issuerRef:
kind: Issuer
name: openstack-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: webhook-server-cert
---
apiVersion: cert-manager.io/v1
Expand Down
3 changes: 3 additions & 0 deletions bindata/rbac/barbican-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,4 +359,7 @@ spec:
issuerRef:
kind: Issuer
name: barbican-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: barbican-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/cinder-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,4 +372,7 @@ spec:
issuerRef:
kind: Issuer
name: cinder-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: cinder-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/designate-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,4 +422,7 @@ spec:
issuerRef:
kind: Issuer
name: designate-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: designate-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/glance-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,4 +388,7 @@ spec:
issuerRef:
kind: Issuer
name: glance-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: glance-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/heat-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,4 +361,7 @@ spec:
issuerRef:
kind: Issuer
name: heat-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: heat-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/horizon-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,4 +312,7 @@ spec:
issuerRef:
kind: Issuer
name: horizon-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: horizon-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/infra-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,4 +539,7 @@ spec:
issuerRef:
kind: Issuer
name: infra-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: infra-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/ironic-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,4 +385,7 @@ spec:
issuerRef:
kind: Issuer
name: ironic-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: ironic-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/keystone-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,4 +395,7 @@ spec:
issuerRef:
kind: Issuer
name: keystone-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: keystone-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/manila-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,4 +371,7 @@ spec:
issuerRef:
kind: Issuer
name: manila-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: manila-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/mariadb-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,4 +333,7 @@ spec:
issuerRef:
kind: Issuer
name: mariadb-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: mariadb-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/neutron-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,4 +366,7 @@ spec:
issuerRef:
kind: Issuer
name: neutron-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: neutron-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/nova-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,4 +431,7 @@ spec:
issuerRef:
kind: Issuer
name: nova-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: nova-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/octavia-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,4 +416,7 @@ spec:
issuerRef:
kind: Issuer
name: octavia-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: octavia-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/openstack-baremetal-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,4 +328,7 @@ spec:
issuerRef:
kind: Issuer
name: openstack-baremetal-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: openstack-baremetal-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/ovn-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,4 +355,7 @@ spec:
issuerRef:
kind: Issuer
name: ovn-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: ovn-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/swift-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,4 +417,7 @@ spec:
issuerRef:
kind: Issuer
name: swift-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: swift-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/telemetry-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,4 +555,7 @@ spec:
issuerRef:
kind: Issuer
name: telemetry-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: telemetry-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/test-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,4 +261,7 @@ spec:
issuerRef:
kind: Issuer
name: test-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: test-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions bindata/rbac/watcher-operator-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,4 +387,7 @@ spec:
issuerRef:
kind: Issuer
name: watcher-operator-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: watcher-operator-metrics-server-cert
3 changes: 3 additions & 0 deletions config/certmanager/certificate-metrics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,7 @@ spec:
issuerRef:
kind: Issuer
name: selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: metrics-server-cert
3 changes: 3 additions & 0 deletions config/certmanager/certificate-webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,7 @@ spec:
issuerRef:
kind: Issuer
name: selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: webhook-server-cert
6 changes: 6 additions & 0 deletions hack/sync-bindata.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ spec:
issuerRef:
kind: Issuer
name: $OPERATOR_NAME-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: $OPERATOR_NAME-webhook-server-cert
---
apiVersion: admissionregistration.k8s.io/v1
Expand Down Expand Up @@ -341,6 +344,9 @@ spec:
issuerRef:
kind: Issuer
name: $OPERATOR_NAME-selfsigned-issuer
privateKey:
algorithm: ECDSA
size: 256
secretName: $OPERATOR_NAME-metrics-server-cert
EOF_CAT

Expand Down
Loading