Skip to content

[DNM] Check update S2I with disable check - #2107

Open
karelyatin wants to merge 1 commit into
openstack-k8s-operators:mainfrom
karelyatin:s2i_check_update
Open

karelyatin wants to merge 1 commit into
openstack-k8s-operators:mainfrom
karelyatin:s2i_check_update

Conversation

@karelyatin

Copy link
Copy Markdown
Contributor

Depends-On: #2070

@openshift-ci
openshift-ci Bot requested review from fultonj and rabi September 24, 2026 07:32
@openshift-ci

openshift-ci Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karelyatin
Once this PR has been reviewed and has the lgtm label, please assign stuggi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 338373 bytes (330KB)
Base branch size 338373 bytes
Change +0.00%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 7476b88d-b54e-442a-aa71-00b9cb339044

📥 Commits

Reviewing files that changed from the base of the PR and between 6c4e4a0 and d6381b6.

📒 Files selected for processing (1)
  • zuul.d/jobs.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Updated the bare-metal minor update configuration so compute nodes and the API, metadata, scheduler, and conductor services use the specified compute service check setting. This keeps the setting consistent across the affected services during the update.

Walkthrough

The openstack-operator-edpm-baremetal-minor-update job sets disable_compute_service_check_for_ffu=true for computes and patches the api, metadata, scheduler, and cell0/cell1 conductor service templates with the same value.

Changes

Minor update job configuration

Layer / File(s) Summary
Configure the compute workaround
zuul.d/jobs.yaml
The job sets disable_compute_service_check_for_ffu=true in the compute extra configuration. It also patches the api, metadata, scheduler, and cell0/cell1 conductor service templates to set the value to true.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: stuggi

Merge Risk: ⚪ Minimal · up to d6381

No actionable issue is established before merge. Confirm that the inherited minor-update job applies the control-plane patch during normal job validation.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the update that disables the compute service check, which matches the main change. The S2I reference is not detailed in the changeset but does not make the title unrelated.
Description check ✅ Passed The description identifies the dependent pull request. This dependency is related to the changeset and satisfies the lenient description requirement.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

Depends-On: openstack-k8s-operators#2070
Signed-off-by: Yatin Karel <ykarel@redhat.com>
@centosinfra-prod-github-app

Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 2070,8c1793ed90ded866478a98f9f8392b24c301f990

@karelyatin

Copy link
Copy Markdown
Contributor Author

recheck depends-on

@centosinfra-prod-github-app

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant