Skip to content

Commit 3bdfef8

Browse files
author
Steve Martinelli
committed
Remove backslash usage from a few tests
Noticed these in the code, figured we should stick to not using backslashes if possible. Change-Id: I55e5402683141e14df7c2b38883b1f3cc2a6bb6a
1 parent ddf0c16 commit 3bdfef8

2 files changed

Lines changed: 12 additions & 27 deletions

File tree

‎openstackclient/tests/identity/v3/test_identity_provider.py‎

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,8 @@ class TestIdentityProvider(identity_fakes.TestFederatedIdentity):
2424
def setUp(self):
2525
super(TestIdentityProvider, self).setUp()
2626

27-
self.identity_providers_mock = self.app.client_manager.\
28-
identity.identity_providers
29-
27+
identity_lib = self.app.client_manager.identity
28+
self.identity_providers_mock = identity_lib.identity_providers
3029
self.identity_providers_mock.reset_mock()
3130

3231

@@ -35,17 +34,10 @@ class TestIdentityProviderCreate(TestIdentityProvider):
3534
def setUp(self):
3635
super(TestIdentityProviderCreate, self).setUp()
3736

38-
self.identity_providers_mock.create.return_value = \
39-
fakes.FakeResource(
40-
None,
41-
copy.deepcopy(identity_fakes.IDENTITY_PROVIDER),
42-
loaded=True,
43-
)
44-
45-
self.cmd = identity_provider.CreateIdentityProvider(
46-
self.app,
47-
None,
48-
)
37+
copied_idp = copy.deepcopy(identity_fakes.IDENTITY_PROVIDER)
38+
resource = fakes.FakeResource(None, copied_idp, loaded=True)
39+
self.identity_providers_mock.create.return_value = resource
40+
self.cmd = identity_provider.CreateIdentityProvider(self.app, None)
4941

5042
def test_create_identity_provider_no_options(self):
5143
arglist = [
@@ -116,12 +108,9 @@ def test_create_identity_provider_disabled(self):
116108
IDENTITY_PROVIDER['enabled'] = False
117109
IDENTITY_PROVIDER['description'] = None
118110

119-
self.identity_providers_mock.create.return_value = \
120-
fakes.FakeResource(
121-
None,
122-
IDENTITY_PROVIDER,
123-
loaded=True,
124-
)
111+
resource = fakes.FakeResource(None, IDENTITY_PROVIDER, loaded=True)
112+
self.identity_providers_mock.create.return_value = resource
113+
125114
arglist = [
126115
'--disable',
127116
identity_fakes.idp_id,

‎openstackclient/tests/identity/v3/test_oauth.py‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,9 @@ class TestRequestTokenAuthorize(TestOAuth1):
7777
def setUp(self):
7878
super(TestRequestTokenAuthorize, self).setUp()
7979

80-
self.request_tokens_mock.authorize.return_value = \
81-
fakes.FakeResource(
82-
None,
83-
copy.deepcopy(identity_fakes.OAUTH_VERIFIER),
84-
loaded=True,
85-
)
86-
80+
copied_verifier = copy.deepcopy(identity_fakes.OAUTH_VERIFIER)
81+
resource = fakes.FakeResource(None, copied_verifier, loaded=True)
82+
self.request_tokens_mock.authorize.return_value = resource
8783
self.cmd = token.AuthorizeRequestToken(self.app, None)
8884

8985
def test_authorize_request_tokens(self):

0 commit comments

Comments
 (0)