Skip to content

Commit ddf0c16

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Fix PEP8 E126 and E202 errors"
2 parents 58583b5 + 4914a8d commit ddf0c16

4 files changed

Lines changed: 369 additions & 329 deletions

File tree

‎openstackclient/tests/identity/v3/test_consumer.py‎

Lines changed: 80 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -19,76 +19,80 @@
1919

2020
class TestOAuth1(identity_fakes.TestOAuth1):
2121

22-
def setUp(self):
23-
super(TestOAuth1, self).setUp()
24-
identity_client = self.app.client_manager.identity
25-
self.consumers_mock = identity_client.oauth1.consumers
26-
self.consumers_mock.reset_mock()
22+
def setUp(self):
23+
super(TestOAuth1, self).setUp()
24+
identity_client = self.app.client_manager.identity
25+
self.consumers_mock = identity_client.oauth1.consumers
26+
self.consumers_mock.reset_mock()
2727

2828

2929
class TestConsumerCreate(TestOAuth1):
3030

31-
def setUp(self):
32-
super(TestConsumerCreate, self).setUp()
31+
def setUp(self):
32+
super(TestConsumerCreate, self).setUp()
3333

34-
self.consumers_mock.create.return_value = fakes.FakeResource(
35-
None, copy.deepcopy(identity_fakes.OAUTH_CONSUMER),
36-
loaded=True)
34+
self.consumers_mock.create.return_value = fakes.FakeResource(
35+
None,
36+
copy.deepcopy(identity_fakes.OAUTH_CONSUMER),
37+
loaded=True,
38+
)
3739

38-
self.cmd = consumer.CreateConsumer(self.app, None)
40+
self.cmd = consumer.CreateConsumer(self.app, None)
3941

40-
def test_create_consumer(self):
41-
arglist = [
42-
'--description', identity_fakes.consumer_description
43-
]
44-
verifylist = [
45-
('description', identity_fakes.consumer_description)
46-
]
47-
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
48-
columns, data = self.cmd.take_action(parsed_args)
42+
def test_create_consumer(self):
43+
arglist = [
44+
'--description', identity_fakes.consumer_description,
45+
]
46+
verifylist = [
47+
('description', identity_fakes.consumer_description),
48+
]
49+
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
50+
columns, data = self.cmd.take_action(parsed_args)
4951

50-
self.consumers_mock.create.assert_called_with(
51-
identity_fakes.consumer_description)
52+
self.consumers_mock.create.assert_called_with(
53+
identity_fakes.consumer_description,
54+
)
5255

53-
collist = ('description', 'id', 'secret')
54-
self.assertEqual(columns, collist)
55-
datalist = (
56-
identity_fakes.consumer_description,
57-
identity_fakes.consumer_id,
58-
identity_fakes.consumer_secret
59-
)
60-
self.assertEqual(data, datalist)
56+
collist = ('description', 'id', 'secret')
57+
self.assertEqual(columns, collist)
58+
datalist = (
59+
identity_fakes.consumer_description,
60+
identity_fakes.consumer_id,
61+
identity_fakes.consumer_secret,
62+
)
63+
self.assertEqual(data, datalist)
6164

6265

6366
class TestConsumerDelete(TestOAuth1):
6467

65-
def setUp(self):
66-
super(TestConsumerDelete, self).setUp()
68+
def setUp(self):
69+
super(TestConsumerDelete, self).setUp()
6770

68-
# This is the return value for utils.find_resource()
69-
self.consumers_mock.get.return_value = fakes.FakeResource(
70-
None,
71-
copy.deepcopy(identity_fakes.OAUTH_CONSUMER),
72-
loaded=True)
71+
# This is the return value for utils.find_resource()
72+
self.consumers_mock.get.return_value = fakes.FakeResource(
73+
None,
74+
copy.deepcopy(identity_fakes.OAUTH_CONSUMER),
75+
loaded=True,
76+
)
7377

74-
self.consumers_mock.delete.return_value = None
75-
self.cmd = consumer.DeleteConsumer(self.app, None)
78+
self.consumers_mock.delete.return_value = None
79+
self.cmd = consumer.DeleteConsumer(self.app, None)
7680

77-
def test_delete_consumer(self):
78-
arglist = [
79-
identity_fakes.consumer_id
80-
]
81-
verifylist = [
82-
('consumer', identity_fakes.consumer_id)
83-
]
84-
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
81+
def test_delete_consumer(self):
82+
arglist = [
83+
identity_fakes.consumer_id,
84+
]
85+
verifylist = [
86+
('consumer', identity_fakes.consumer_id),
87+
]
88+
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
8589

86-
result = self.cmd.run(parsed_args)
87-
self.assertEqual(result, 0)
90+
result = self.cmd.run(parsed_args)
91+
self.assertEqual(result, 0)
8892

89-
self.consumers_mock.delete.assert_called_with(
90-
identity_fakes.consumer_id,
91-
)
93+
self.consumers_mock.delete.assert_called_with(
94+
identity_fakes.consumer_id,
95+
)
9296

9397

9498
class TestConsumerList(TestOAuth1):
@@ -125,7 +129,7 @@ def test_consumer_list(self):
125129
self.assertEqual(columns, collist)
126130
datalist = ((
127131
identity_fakes.consumer_id,
128-
identity_fakes.consumer_description
132+
identity_fakes.consumer_description,
129133
), )
130134
self.assertEqual(tuple(data), datalist)
131135

@@ -138,29 +142,33 @@ def setUp(self):
138142
consumer_no_secret = copy.deepcopy(identity_fakes.OAUTH_CONSUMER)
139143
del consumer_no_secret['secret']
140144
self.consumers_mock.get.return_value = fakes.FakeResource(
141-
None, consumer_no_secret, loaded=True)
145+
None,
146+
consumer_no_secret,
147+
loaded=True,
148+
)
142149

143150
# Get the command object to test
144151
self.cmd = consumer.ShowConsumer(self.app, None)
145152

146153
def test_consumer_show(self):
147154
arglist = [
148-
identity_fakes.consumer_id
155+
identity_fakes.consumer_id,
149156
]
150157
verifylist = [
151-
('consumer', identity_fakes.consumer_id)
158+
('consumer', identity_fakes.consumer_id),
152159
]
153160
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
154161
columns, data = self.cmd.take_action(parsed_args)
155162

156163
self.consumers_mock.get.assert_called_with(
157-
identity_fakes.consumer_id)
164+
identity_fakes.consumer_id,
165+
)
158166

159-
collist = ('description', 'id' )
167+
collist = ('description', 'id')
160168
self.assertEqual(columns, collist)
161169
datalist = (
162170
identity_fakes.consumer_description,
163-
identity_fakes.consumer_id
171+
identity_fakes.consumer_id,
164172
)
165173
self.assertEqual(data, datalist)
166174

@@ -171,12 +179,18 @@ def setUp(self):
171179
super(TestConsumerSet, self).setUp()
172180

173181
self.consumers_mock.get.return_value = fakes.FakeResource(
174-
None, copy.deepcopy(identity_fakes.OAUTH_CONSUMER), loaded=True)
182+
None,
183+
copy.deepcopy(identity_fakes.OAUTH_CONSUMER),
184+
loaded=True,
185+
)
175186

176187
consumer_updated = copy.deepcopy(identity_fakes.OAUTH_CONSUMER)
177188
consumer_updated['description'] = "consumer new description"
178189
self.consumers_mock.update.return_value = fakes.FakeResource(
179-
None, consumer_updated, loaded=True)
190+
None,
191+
consumer_updated,
192+
loaded=True,
193+
)
180194

181195
self.cmd = consumer.SetConsumer(self.app, None)
182196

@@ -185,16 +199,18 @@ def test_consumer_update(self):
185199

186200
arglist = [
187201
'--description', new_description,
188-
identity_fakes.consumer_id
202+
identity_fakes.consumer_id,
189203
]
190204
verifylist = [
191205
('description', new_description),
192-
('consumer', identity_fakes.consumer_id)
206+
('consumer', identity_fakes.consumer_id),
193207
]
194208
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
195209
result = self.cmd.run(parsed_args)
196210
self.assertEqual(result, 0)
197211

198212
kwargs = {'description': new_description}
199213
self.consumers_mock.update.assert_called_with(
200-
identity_fakes.consumer_id, **kwargs)
214+
identity_fakes.consumer_id,
215+
**kwargs
216+
)

0 commit comments

Comments
 (0)