Skip to content

clean clone for src build - #4475

Merged
dtrawins merged 1 commit into
mainfrom
build-src-clean
Aug 27, 2026
Merged

clean clone for src build#4475
dtrawins merged 1 commit into
mainfrom
build-src-clean

Conversation

@dtrawins

@dtrawins dtrawins commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

🛠 Summary

Build OV components always from clean repo to avoid CI issues with previous state.

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copilot AI lite review requested due to automatic review settings August 25, 2026 12:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Windows dependency install script to force a clean re-clone of OpenVINO-related source repositories when building OpenVINO from source, rather than reusing any existing local checkouts under %BAZEL_SHORT_PATH%.

Changes:

  • Always remove and re-clone %BAZEL_SHORT_PATH%\openvino_src before building OpenVINO from source.
  • Always remove and re-clone %BAZEL_SHORT_PATH%\openvino_tokenizers_src before building/installing OpenVINO Tokenizers.
  • Always remove and re-clone %BAZEL_SHORT_PATH%\openvino_genai_src before building/installing OpenVINO GenAI.
Suppressed comments (2)

windows_install_build_dependencies.bat:274

  • This Tokenizers block deletes and reclones the repo but does not check errorlevel after rmdir or git clone. If either fails, the following cd/git operations may execute from the wrong directory and only fail later, which is hard to diagnose.
IF /I EXIST %BAZEL_SHORT_PATH%\openvino_tokenizers_src (
    rmdir /S /Q %BAZEL_SHORT_PATH%\openvino_tokenizers_src
)

git clone https://github.com/%OV_TOKENIZERS_ORG%/openvino_tokenizers.git %BAZEL_SHORT_PATH%\openvino_tokenizers_src

windows_install_build_dependencies.bat:298

  • This GenAI block deletes and reclones the repo but does not check errorlevel after rmdir or git clone. If those steps fail, later commands (cd, git fetch/checkout/pull) can run from an unexpected working directory before failing, reducing script reliability.
IF /I EXIST %BAZEL_SHORT_PATH%\openvino_genai_src (
    rmdir /S /Q %BAZEL_SHORT_PATH%\openvino_genai_src
)

git clone https://github.com/%OV_GENAI_ORG%/openvino.genai.git %BAZEL_SHORT_PATH%\openvino_genai_src

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 240 to +244
IF /I EXIST %BAZEL_SHORT_PATH%\openvino_src (
git -C %BAZEL_SHORT_PATH%\openvino_src remote -v | findstr "\/%OV_SOURCE_ORG%\/" > nul
if !errorlevel! equ 0 (
echo [INFO] Repository already points to %OV_SOURCE_ORG%
) else (
echo [INFO] Repository points to different org, removing...
rmdir /S /Q %BAZEL_SHORT_PATH%\openvino_src
)
rmdir /S /Q %BAZEL_SHORT_PATH%\openvino_src
)

IF /I NOT EXIST %BAZEL_SHORT_PATH%\openvino_src (
git clone https://github.com/%OV_SOURCE_ORG%/openvino %BAZEL_SHORT_PATH%\openvino_src
)
git clone https://github.com/%OV_SOURCE_ORG%/openvino %BAZEL_SHORT_PATH%\openvino_src
@dtrawins
dtrawins merged commit dc138c3 into main Aug 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants