Remove leftover comments - #4484
Merged
Merged
Conversation
mzegla
requested review from
atobiszei and
rasapala
and
a lite review from Copilot
August 27, 2026 08:44
atobiszei
approved these changes
Aug 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up test sources by removing leftover TODO/FIXME comments, aligning the tests with a “no unresolved notes in-tree” approach.
Changes:
- Removed TODO/FIXME suffixes from two MediaPipe negative-framework tests.
- Removed an inline FIXME comment from the Minja chat template end-to-end test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/test/mediapipe_framework_test.cpp |
Removes leftover TODO/FIXME comments in MediaPipe negative framework tests. |
src/test/llm/chat_template_end_to_end_minja_test.cpp |
Removes a leftover inline FIXME comment from an LLM chat-template expected output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| } | ||
| TEST_F(MediapipeNegativeFrameworkTest, ExceptionDuringGetContract) { // TODO FIXME add checks to exception handling? | ||
| TEST_F(MediapipeNegativeFrameworkTest, ExceptionDuringGetContract) { |
rasapala
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.