Add igc driver - #4515
Open
rasapala wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new Intel APT-repo install path introduces non-reproducible builds and needs tightening (version pinning and key/dependency handling) before it can be safely approved.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Ubuntu GPU driver installation script to additionally install the Intel IGC CM component (intel-igc-cm) for the 26.18.38308 driver version path by temporarily adding Intel’s GPU APT repository during the build.
Changes:
- Adds Intel GPU APT repo key + repo entry for Ubuntu based on
VERSION_CODENAME. - Installs
intel-igc-cmand then removes the repo list entry and purges temporary tooling packages.
File summaries
| File | Description |
|---|---|
| install_ubuntu_gpu_drivers.sh | Adds an APT-repo-based install step for intel-igc-cm in the 26.18.38308 branch. |
Review details
Suppressed comments (1)
install_ubuntu_gpu_drivers.sh:110
- Installing
intel-igc-cmfrom a live Intel APT repository without pinning a package version makes the Docker build non-reproducible (the repository contents can change over time, producing different images or breaking builds). Consider switching to an explicit.debartifact like the other driver branches here, or pin the exactintel-igc-cmversion (and optionally the repo snapshot) you expect to use.
echo "deb [arch=amd64 signed-by=/usr/share/keyrings/intel-graphics.gpg] https://repositories.intel.com/gpu/ubuntu ${VERSION_CODENAME}/lts/2523 unified" \
> /etc/apt/sources.list.d/intel-gpu-${VERSION_CODENAME}.list && \
apt-get update && apt-get install -y --no-install-recommends intel-igc-cm && \
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…it/model_server into update_gpu_driver2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA CVS-193959
Installs both intel-igc-cm 66 MB and dependency - libigc2 90MB
🧪 Checklist
``