Skip to content

Add igc driver - #4515

Open
rasapala wants to merge 5 commits into
mainfrom
update_gpu_driver2
Open

Add igc driver#4515
rasapala wants to merge 5 commits into
mainfrom
update_gpu_driver2

Conversation

@rasapala

@rasapala rasapala commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

🛠 Summary

JIRA CVS-193959
Installs both intel-igc-cm 66 MB and dependency - libigc2 90MB

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copilot AI lite review requested due to automatic review settings September 7, 2026 09:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new Intel APT-repo install path introduces non-reproducible builds and needs tightening (version pinning and key/dependency handling) before it can be safely approved.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the Ubuntu GPU driver installation script to additionally install the Intel IGC CM component (intel-igc-cm) for the 26.18.38308 driver version path by temporarily adding Intel’s GPU APT repository during the build.

Changes:

  • Adds Intel GPU APT repo key + repo entry for Ubuntu based on VERSION_CODENAME.
  • Installs intel-igc-cm and then removes the repo list entry and purges temporary tooling packages.
File summaries
File Description
install_ubuntu_gpu_drivers.sh Adds an APT-repo-based install step for intel-igc-cm in the 26.18.38308 branch.
Review details

Suppressed comments (1)

install_ubuntu_gpu_drivers.sh:110

  • Installing intel-igc-cm from a live Intel APT repository without pinning a package version makes the Docker build non-reproducible (the repository contents can change over time, producing different images or breaking builds). Consider switching to an explicit .deb artifact like the other driver branches here, or pin the exact intel-igc-cm version (and optionally the repo snapshot) you expect to use.
	echo "deb [arch=amd64 signed-by=/usr/share/keyrings/intel-graphics.gpg] https://repositories.intel.com/gpu/ubuntu ${VERSION_CODENAME}/lts/2523 unified" \
		> /etc/apt/sources.list.d/intel-gpu-${VERSION_CODENAME}.list && \
	apt-get update && apt-get install -y --no-install-recommends intel-igc-cm && \
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread install_ubuntu_gpu_drivers.sh Outdated
@rasapala
rasapala requested review from dtrawins and mzegla September 7, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants