Embeddings --max_length parameter - error message when value is grater then model's max length - #4521
Open
przepeck wants to merge 1 commit into
Open
Embeddings --max_length parameter - error message when value is grater then model's max length#4521przepeck wants to merge 1 commit into
przepeck wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new failure path should provide a single, fully-informative exception message (including relevant values/context) and should be backed by a regression test for invalid max_length configurations.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR hardens the embeddings servable initialization by validating that a graph-configured max_length does not exceed the model’s detected maximum length (from config.json), preventing previously silent/undefined failures.
Changes:
- Add a validation check for
configuredMaxLengthvs. detectedmaxModelLength. - Emit an error and throw to stop initialization when the configuration is invalid.
File summaries
| File | Description |
|---|---|
src/embeddings/embeddings_servable.cpp |
Adds a guard that rejects max_length values greater than the model’s detected maximum length during preprocessing setup. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dtrawins
approved these changes
Sep 8, 2026
przepeck
force-pushed
the
przepeck/embeddings_max_length_fix
branch
from
September 8, 2026 12:47
8725c3a to
5d677da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
OVMS was silently failing when the
--max_lengthparameter was grater then model's max length. Adding error message and OV_THROW to stop server.🧪 Checklist
``