Repository navigation
Conversation
The `showOldAnswers` parameter was propagated in site navigation links, problem navigation links, and a hidden field on the problem page, but is never used when rendering a problem. That propagation is removed. The `generateURLs` method copied the `showCorrectAnswers`, `showHints`, `showOldAnswers`, and `showSolutions` parameters into the emailable URL. Only `showCorrectAnswers` affects rendering, and only via the instructor-only "Show Correct Answers" button. On the feedback page the values were the display permissions, so `showCorrectAnswers=1` was added after the answer date and the instructor got the correct-answers-only view instead of what the student saw. None of these are added anymore. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
drgrice1
force-pushed
the
problem-url-param-cleanup
branch
from
November 9, 2026 17:40
a6e9ade to
fe76ad9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
showOldAnswersparameter was propagated in site navigation links, problem navigation links, and a hidden field on the problem page, but is never used when rendering a problem. That propagation is removed.The
generateURLsmethod copied theshowCorrectAnswers,showHints,showOldAnswers, andshowSolutionsparameters into the emailable URL. OnlyshowCorrectAnswersaffects rendering, and only via the instructor-only "Show Correct Answers" button. On the feedback page the values were the display permissions, soshowCorrectAnswers=1was added after the answer date and the instructor got the correct-answers-only view instead of what the student saw. None of these are added anymore.