retain old books based on collection settings - #520
Merged
Merged
Conversation
elfkuzco
added this pull request to stack #521
September 17, 2026 15:30
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
+ Coverage 81.80% 81.91% +0.11%
==========================================
Files 70 70
Lines 4435 4452 +17
Branches 523 527 +4
==========================================
+ Hits 3628 3647 +19
+ Misses 643 642 -1
+ Partials 164 163 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
benoit74
requested changes
Sep 18, 2026
benoit74
left a comment
Contributor
There was a problem hiding this comment.
Thank you, two small remarks.
elfkuzco
force-pushed
the
retain-old-books
branch
from
September 21, 2026 08:01
d4d112d to
61a4f7f
Compare
elfkuzco
force-pushed
the
retain-old-books
branch
from
September 21, 2026 08:38
61a4f7f to
4b0f7b8
Compare
elfkuzco
force-pushed
the
retain-old-books
branch
from
September 21, 2026 08:41
4b0f7b8 to
08d789b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR enhances the logic to apply retention rules by not applying the rules for titles that belong to a collection with setting
retain_old_books.Changes
retain_old_booksto collection and collection historyretain_old_booksset to Trueretain_old_booksThis closes #517