Skip to content

chore: update Kubernetes dependencies to 1.37 and regenerate CRDs - #530

Merged
openshift-merge-bot[bot] merged 2 commits into
operator-framework:masterfrom
tmshort:fix/pr-522-generated-crds
Oct 28, 2026
Merged

openshift-merge-bot[bot] merged 2 commits into
operator-framework:masterfrom
tmshort:fix/pr-522-generated-crds

Conversation

@tmshort

@tmshort tmshort commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Summary

Updates Kubernetes modules to v0.37.1 and controller-runtime to v0.25.2, carrying forward the dependency bump from #522.

Regenerates the ClusterServiceVersion and Subscription CRDs and their embedded definitions for the new Kubernetes APIs. This resolves the failing verify check on #522.

Adds formatting steps to the embedded CRD generator. go-bindata emits a package comment that needs two gofmt passes to reach a stable form, keeping subsequent make verify runs clean.

This PR targets master and supersedes #522.

Validation

  • GOCACHE=/tmp/api522-gocache make verify GOBIN=/tmp/api522-bin
  • GOCACHE=/tmp/api522-gocache make test-unit GOBIN=/tmp/api522-bin

Both passed locally. The unit suite includes Docker-backed multi-architecture tests.

dependabot Bot and others added 2 commits October 28, 2026 13:38
Bumps the k8s-dependencies group with 5 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.36.4` | `0.37.1` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.36.4` | `0.37.1` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.36.4` | `0.37.1` |
| [k8s.io/kube-openapi](https://github.com/kubernetes/kube-openapi) | `0.0.0-20260317180543-43fb72c5454a` | `0.0.0-20260721132016-d427ff9ee9ad` |
| [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.24.1` | `0.25.2` |



Updates `k8s.io/apiextensions-apiserver` from 0.36.4 to 0.37.1
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.36.4...v0.37.1)

Updates `k8s.io/apimachinery` from 0.36.4 to 0.37.1
- [Commits](kubernetes/apimachinery@v0.36.4...v0.37.1)

Updates `k8s.io/client-go` from 0.36.4 to 0.37.1
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.36.4...v0.37.1)

Updates `k8s.io/kube-openapi` from 0.0.0-20260317180543-43fb72c5454a to 0.0.0-20260721132016-d427ff9ee9ad
- [Commits](https://github.com/kubernetes/kube-openapi/commits)

Updates `sigs.k8s.io/controller-runtime` from 0.24.1 to 0.25.2
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.24.1...v0.25.2)

---
updated-dependencies:
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-version: 0.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-version: 0.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-version: 0.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/kube-openapi
  dependency-version: 0.0.0-20260721132016-d427ff9ee9ad
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-version: 0.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Todd Short <tshort@redhat.com>
@openshift-ci
openshift-ci Bot requested review from fgiudici and grokspawn October 28, 2026 14:17
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 08419d07-43ed-404d-abff-7bd0b4a837da
Commits

Reviewing files that changed from the base of the PR and between 65c1042 and 034fc01.

Files ignored due to path filters: 1
  • go.sum is excluded by !**/*.sum
Files selected for processing: 5
  • crds/defs.go
  • crds/operators.coreos.com_clusterserviceversions.yaml
  • crds/operators.coreos.com_subscriptions.yaml
  • crds/zz_defs.go
  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The pull request updates Kubernetes dependencies and expands the ClusterServiceVersion and Subscription CRD schemas. The schemas add probe, pod, and volume fields, and revise descriptions for existing fields.

Changes: Kubernetes CRD schema refresh

Layer / File(s) Summary
Dependency and generation updates
go.mod, crds/defs.go
Kubernetes and related dependencies are updated. Two gofmt directives are added to the generated definitions file.
Pod and probe schema fields
crds/operators.coreos.com_clusterserviceversions.yaml, crds/operators.coreos.com_subscriptions.yaml
The schemas add probe protocol and mode fields and bind mount options. The ClusterServiceVersion schema also adds eviction responders and updates pod-related descriptions.
Volume ownership and permission fields
crds/operators.coreos.com_clusterserviceversions.yaml, crds/operators.coreos.com_subscriptions.yaml
The schemas add default and item-level file-owner UIDs for volume sources and projections, plus the emptyDir permission mode.
Schema description updates
crds/operators.coreos.com_clusterserviceversions.yaml, crds/operators.coreos.com_subscriptions.yaml
The schemas clarify RBAC field names and ConfigMap key behavior, and revise descriptions for volume data-source feature gates.

Priority: Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to 034fc

The updated schemas expose newer Kubernetes fields. No merge-blocking issue was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: regenerating the CRDs for the Kubernetes 1.37 dependency update.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (3 skipped: 3 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.33%. Comparing base (65c1042) to head (034fc01).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   22.33%   22.33%           
=======================================
  Files          60       60           
  Lines        7872     7872           
=======================================
  Hits         1758     1758           
  Misses       5962     5962           
  Partials      152      152           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
tmshort changed the base branch from dependabot/go_modules/k8s-dependencies-20f0d38923 to master October 28, 2026 14:20
@perdasilva

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2026
@tmshort tmshort added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 28, 2026

@rashmigottipati rashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2026
@openshift-ci

openshift-ci Bot commented Oct 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 34b0cf6 into operator-framework:master Oct 28, 2026
8 checks passed
@tmshort
tmshort deleted the fix/pr-522-generated-crds branch October 28, 2026 14:34
@tmshort tmshort changed the title fix: regenerate CRDs for Kubernetes 1.37 chore: update Kubernetes dependencies to 1.37 and regenerate CRDs Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies Pull requests that update a dependency file go Pull requests that update Go code lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants