improve: add sharding sample as integration test#3460
Merged
Conversation
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new sharding-focused sample integration test under operator-framework to demonstrate splitting reconciliation responsibility across multiple operator instances using shard selectors (leveraging Kubernetes’ ShardedListAndWatch feature gate).
Changes:
- Introduces a new
ShardSelectorITSsample test that starts twoOperatorinstances with different shard selectors and asserts a resource is reconciled by exactly one of them. - Adds a minimal custom resource type (
ShardSelectorTestCustomResource) used by the sample test. - Adds a simple reconciler (
ShardSelectorTestReconciler) that counts executions to support assertions in the test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/shardselector/ShardSelectorITS.java | New sample test that runs two operators with different shard selectors and verifies exclusive reconciliation. |
| operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/shardselector/ShardSelectorTestCustomResource.java | Test custom resource definition used by the sharding sample. |
| operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/shardselector/ShardSelectorTestReconciler.java | Test reconciler that increments an execution counter for assertions. |
| kubeAPIVersion = "1.36.*", | ||
| apiServerFlags = {"--feature-gates=ShardedListAndWatch=true"}, | ||
| updateKubeConfigFile = true) | ||
| class ShardSelectorITS { |
Collaborator
Author
There was a problem hiding this comment.
Well was, but changed it, fits better to IT.
xstefank
approved these changes
Jul 1, 2026
| kubeAPIVersion = "1.36.*", | ||
| apiServerFlags = {"--feature-gates=ShardedListAndWatch=true"}, | ||
| updateKubeConfigFile = true) | ||
| class ShardSelectorITS { |
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
xstefank
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros a_meszaros@apple.com