improve: additional tests for event filtering#3461
Open
csviri wants to merge 3 commits into
Open
Conversation
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends unit test coverage around informer event filtering, adding additional scenarios to validate how EventFilterSupport/EventFilterWindow emit or suppress events across edge cases.
Changes:
- Added a basic “no active window” processing test for
processEvent. - Added new edge-case tests covering deletes during active updates without recorded own versions, synth event construction from leading ADD, handling of leading DELETE, and ghost removal on lingering windows.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+614
to
+616
| assertThat(support.doneEventFilterModify(RESOURCE_ID)) | ||
| .hasValueSatisfying(e -> assertThat(e.getAction()).isEqualTo(UPDATED)); | ||
| assertThat(support.isActiveUpdateFor(RESOURCE_ID)).isFalse(); |
Comment on lines
+627
to
+631
| assertThat(support.processEvent(RESOURCE_ID, deleteEvent(FIRST_OWN_VERSION - 1))).isEmpty(); | ||
| assertThat(support.processEvent(RESOURCE_ID, updateEvent(FIRST_OWN_VERSION))).isEmpty(); | ||
| assertThat(support.processEvent(RESOURCE_ID, updateEvent(FIRST_OWN_VERSION + 2))) | ||
| .hasValueSatisfying(e -> assertThat(e.getAction()).isEqualTo(UPDATED)); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros a_meszaros@apple.com