Repository navigation
Conversation
The client moved to Jackson 3, so the direct Jackson usages are migrated to the tools.jackson packages. YamlConfigProvider keeps throwing UncheckedIOException for malformed YAML. Tests calling the now ambiguous withShardSelector(null) cast the argument to String, and a v5.7 migration guide describes the changes for users.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The major client and serialization upgrade needs build and Kubernetes integration validation that was unavailable in this review.
No open issues 🎉
What changed in this PR
Upgrades Java Operator SDK to Fabric8 Kubernetes Client 8.0.0 and adapts direct Jackson usage to Jackson 3.
Changes:
- Migrates Jackson imports and APIs while preserving
UncheckedIOExceptionfor YAML loading failures. - Disambiguates null shard selectors in informer tests.
- Adds v5.7 migration guidance for downstream users.
| File | Description |
|---|---|
pom.xml |
Upgrades Fabric8 Kubernetes Client to 8.0.0. |
operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/multiversioncrd/MultiVersionCRDIT.java |
Migrates JSON access and exception handling to Jackson 3. |
operator-framework/src/main/java/io/javaoperatorsdk/operator/config/loader/provider/YamlConfigProvider.java |
Updates YAML parsing while preserving exception behavior. |
operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSourceStartFailureTest.java |
Casts the null shard selector to String. |
operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSourcePoolIdentityTest.java |
Casts the null shard selector to String. |
operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSourceNamespaceChangeTest.java |
Casts the null shard selector to String. |
operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/matcher/MatcherUtils.java |
Migrates JSON imports and property iteration. |
operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcher.java |
Migrates JSON imports and string access. |
operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java |
Updates the Javadoc mapper reference to Jackson 3. |
docs/content/en/docs/migration/v5-7-migration.md |
Documents Jackson 3 and shard-selector migration steps. |
Review effort: Balanced
kubernetes-client 8.0.0 depends on kubernetes-httpclient-vertx-5 at runtime, which clashed with the Vert.x 4 client in micrometer-support. Exclude it from operator-framework-core so only the explicitly selected implementation is on the classpath. Manage vertx-5 in the root pom and use it in the CI http client matrix, as vertx now refers to Vert.x 4.
Excluding kubernetes-httpclient-vertx-5 left the core module without any http client implementation on its test classpath, which broke OperatorIT. Use the implementation selected by the fabric8-httpclient-impl.name property.
xstefank
approved these changes
Oct 27, 2026
csviri
added a commit
that referenced
this pull request
Oct 27, 2026
The client moved to Jackson 3, so the direct Jackson usages are migrated to the tools.jackson packages. YamlConfigProvider keeps throwing UncheckedIOException for malformed YAML. Tests calling the now ambiguous withShardSelector(null) cast the argument to String, and a v5.7 migration guide describes the changes for users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client moved to Jackson 3, so the direct Jackson usages are migrated to the tools.jackson packages. YamlConfigProvider keeps throwing UncheckedIOException for malformed YAML. Tests calling the now ambiguous withShardSelector(null) cast the argument to String, and a v5.7 migration guide describes the changes for users.