Skip to content

Fix/desired state aspects - #3667

Draft
csviri wants to merge 2 commits into
nextfrom
fix/desired-state-aspects
Draft

csviri wants to merge 2 commits into
nextfrom
fix/desired-state-aspects

Conversation

@csviri

@csviri csviri commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

csviri and others added 2 commits October 28, 2026 10:30
Applying the desired state aspects inside computeIfAbsent failed with
"Recursive update" when an aspect looked up the actual resource of the
dependent (same key) or of another dependent whose key landed in the same
bin. Compute with a lock per dependent instead, and hand the thread already
computing a desired state the state as it is so far.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…er configuration

Hand the user's bulk dependent, rather than the stand-in the framework creates per resource, to the
desired state aspects, and skip the aspects if the context has no controller configuration.
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2026
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant