Skip to content

🌱 fix: align OTel versions to v1.44.0 and use explicit e2e timeout fallback#2791

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:coderabbit
Jul 2, 2026
Merged

🌱 fix: align OTel versions to v1.44.0 and use explicit e2e timeout fallback#2791
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:coderabbit

Conversation

@tmshort

@tmshort tmshort commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Discovered when code was being downstreamed.

  • Upgrade go.opentelemetry.io/otel/exporters/otlp/otlptrace, otlptracegrpc, and otel/sdk from v1.43.0 to v1.44.0 to match otel, otel/metric, and otel/trace already at v1.44.0
  • Move E2E_TIMEOUT fallback from target-specific ?= into the e2e-run-% recipe via $(or $(E2E_TIMEOUT),20m) so the 20m default is explicit and the 25m override from test-experimental-e2e is unambiguous

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Copilot AI review requested due to automatic review settings June 30, 2026 14:23
@openshift-ci openshift-ci Bot requested a review from oceanc80 June 30, 2026 14:23
@netlify

netlify Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit a33a69e
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6a43dbdfdd7c70000880695f
😎 Deploy Preview https://deploy-preview-2791--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci Bot requested a review from perdasilva June 30, 2026 14:23
Copilot AI reviewed Jun 30, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates dependency versions to keep OpenTelemetry (OTel) components consistent and adjusts the Makefile’s e2e test invocation so the default go test -timeout fallback is explicit at the call site (while still allowing variant-specific overrides).

Changes:

  • Bump selected OTel Go module dependencies to v1.44.0 to match other OTel modules already at v1.44.0.
  • Update the e2e-run-% recipe to use an explicit -timeout $(or $(E2E_TIMEOUT),20m) fallback, making default/override behavior unambiguous.
  • Refresh related indirect dependency versions and checksums (grpc-gateway, genproto, etc.) as part of module resolution.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
Makefile Makes the e2e go test -timeout default explicit via $(or $(E2E_TIMEOUT),20m) while preserving overrides (e.g., experimental uses 25m).
go.mod Updates indirect dependency versions, including OTel trace exporter + SDK to v1.44.0.
go.sum Updates corresponding module checksums and records the resolved dependency graph.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go.mod
@codecov

codecov Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.29%. Comparing base (c3caa22) to head (a33a69e).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2791      +/-   ##
==========================================
- Coverage   70.44%   70.29%   -0.16%     
==========================================
  Files         143      142       -1     
  Lines       10625    10577      -48     
==========================================
- Hits         7485     7435      -50     
- Misses       2579     2580       +1     
- Partials      561      562       +1
Flag Coverage Δ
e2e 35.27% <ø> (+0.15%) ⬆️
experimental-e2e 52.62% <ø> (+0.20%) ⬆️
unit 59.32% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva

perdasilva commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2026
rashmigottipati
rashmigottipati approved these changes Jun 30, 2026
View reviewed changes

@rashmigottipati rashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tmshort @claude
fix: align OTel versions to v1.44.0 and use explicit e2e timeout fall…
a33a69e 
…back

- Upgrade go.opentelemetry.io/otel/exporters/otlp/otlptrace,
  otlptracegrpc, and otel/sdk from v1.43.0 to v1.44.0 to match otel,
  otel/metric, and otel/trace already at v1.44.0
- Move E2E_TIMEOUT fallback from target-specific ?= into the e2e-run-%
  recipe via $(or $(E2E_TIMEOUT),20m) so the 20m default is explicit
  and the 25m override from test-experimental-e2e is unambiguous

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Todd Short <tshort@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2026
rashmigottipati
rashmigottipati approved these changes Jul 1, 2026
View reviewed changes

@rashmigottipati rashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2026
@perdasilva

perdasilva commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit d0252d4 into operator-framework:main Jul 2, 2026
25 checks passed
@tmshort tmshort deleted the coderabbit branch July 2, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@rashmigottipati rashmigottipati rashmigottipati approved these changes
@oceanc80 oceanc80 Awaiting requested review from oceanc80
@perdasilva perdasilva Awaiting requested review from perdasilva

Assignees

@perdasilva perdasilva

@rashmigottipati rashmigottipati

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmshort @perdasilva @rashmigottipati