Skip to content

🐛 fix: missing olm.operatorNamespace annotation#2803

Open
Kajot-dev wants to merge 1 commit into
operator-framework:mainfrom
Kajot-dev:fix/olm.operatorNamespace
Open

🐛 fix: missing olm.operatorNamespace annotation#2803
Kajot-dev wants to merge 1 commit into
operator-framework:mainfrom
Kajot-dev:fix/olm.operatorNamespace

Conversation

@Kajot-dev

@Kajot-dev Kajot-dev commented Jul 2, 2026

Copy link
Copy Markdown

Description

OLMv0 sets the olm.* annotations from OperatorGroup on the spec.template.metadata.annotation section of the operator Deployment. To maintain interoperability OLM v1 does do the same for olm.targetNamespaces annotation - but does NOT do it for olm.operatorNamespace. There are opeators that rely on this (see linked issue)

Fixes: #2802

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: jjaruszewski <jjaruszewski@man.poznan.pl>
Copilot AI review requested due to automatic review settings July 2, 2026 16:35
@openshift-ci openshift-ci Bot requested review from dtfranz and grokspawn July 2, 2026 16:35
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign grokspawn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Jul 2, 2026

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 723c986
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6a46935e2aab300008ff5318
😎 Deploy Preview https://deploy-preview-2803--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores OLMv0 interoperability by ensuring generated CSV-based Deployment pod templates include the olm.operatorNamespace annotation (alongside the existing olm.targetNamespaces) so operators relying on those annotations behave correctly under OLMv1.

Changes:

  • Set olm.operatorNamespace on generated Deployment.spec.template.metadata.annotations from render.Options.InstallNamespace.
  • Update unit tests to assert the new annotation is present in generated deployment templates.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
internal/operator-controller/rukpak/render/registryv1/generators/generators.go Adds olm.operatorNamespace to generated CSV deployment pod-template annotations (OLMv0 parity).
internal/operator-controller/rukpak/render/registryv1/generators/generators_test.go Updates expected deployment-template annotations to include olm.operatorNamespace.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

olm.operatorNamespace annotation is missing

2 participants