🐛 fix: use static permissions in update-demos workflow#2805
Conversation
GitHub Actions does not support expressions in the permissions block. The dynamic expression was causing every workflow run to fail with "workflow file issue" before any job could start. Use static contents:write (matching pages.yaml convention). The deploy step is already gated by `if: github.event_name == 'push'`. Co-Authored-By: Claude <noreply@anthropic.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Fixes the update-demos GitHub Actions workflow so it can run again by removing an unsupported expression from the permissions block (which was preventing workflow runs from starting at all).
Changes:
- Replaced dynamic
contentspermission expression with a staticcontents: writevalue. - Restored workflow validity so
update-demoscan execute (deploy remains gated topushvia an existingif:condition).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-merge-bot
Bot
merged commit a918ca8
into
operator-framework:main
Description
GitHub Actions does not support expressions in the
permissionsblock.The dynamic expression introduced in #2801 was causing every
update-demosworkflow run to fail with "workflow file issue" before any job could start.
This changes
contents: ${{ github.event_name == 'push' && 'write' || 'read' }}to static
contents: write(matching thepages.yamlconvention). The deploystep is already gated by
if: github.event_name == 'push', so the writepermission on PR runs is unused.
Failed runs:
Reviewer Checklist