Skip to content

🌱 Update api to v0.46.0 and operator-registry/v2 to alpha-3 - #3080

Open
tmshort wants to merge 1 commit into
operator-framework:mainfrom
tmshort:chore/api-v0.46.0-registry-v2-alpha3
Open

tmshort wants to merge 1 commit into
operator-framework:mainfrom
tmshort:chore/api-v0.46.0-registry-v2-alpha3

Conversation

@tmshort

@tmshort tmshort commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Description

Update github.com/operator-framework/api to v0.46.0 and migrate operator-registry imports and the direct dependency to github.com/operator-framework/operator-registry/v2@v2.0.0-alpha-3. The registry v2 module requires Go 1.26.5, so the module's Go version also advances.

The go-verdiff check requires the go-verdiff-override label for this necessary Go version update.

Validation

  • go mod tidy and go mod verify
  • go build -p 2 -tags=containers_image_openpgp ./cmd/...
  • go test -p 2 -tags=containers_image_openpgp for catalog metadata, resolver, registry v1 renderer, bundle utilities, and catalogd GraphQL, storage, and service packages. Tests needing localhost listeners were rerun with socket access.
  • git diff --check

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Todd Short <tshort@redhat.com>
@openshift-ci

openshift-ci Bot commented Oct 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevinrizza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from fgiudici and perdasilva October 28, 2026 19:11
@netlify

netlify Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 13d9a4a
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6ae248f6f93c45e66e7da8df
😎 Deploy Preview https://deploy-preview-3080--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: d7b3f0a7-f575-48f0-93e5-8e1955c29128
Commits

Reviewing files that changed from the base of the PR and between 255a402 and 13d9a4a.

Files ignored due to path filters: 1
  • go.sum is excluded by !**/*.sum
Files selected for processing: 31
  • go.mod
  • internal/catalogd/graphql/discovery_test.go
  • internal/catalogd/graphql/graphql.go
  • internal/catalogd/graphql/graphql_test.go
  • internal/catalogd/service/graphql_service_test.go
  • internal/catalogd/storage/index.go
  • internal/catalogd/storage/index_test.go
  • internal/catalogd/storage/localdir.go
  • internal/catalogd/storage/localdir_test.go
  • internal/operator-controller/bundleutil/bundle.go
  • internal/operator-controller/bundleutil/bundle_test.go
  • internal/operator-controller/catalogmetadata/cache/cache.go
  • internal/operator-controller/catalogmetadata/client/client.go
  • internal/operator-controller/catalogmetadata/client/client_test.go
  • internal/operator-controller/catalogmetadata/compare/compare.go
  • internal/operator-controller/catalogmetadata/compare/compare_test.go
  • internal/operator-controller/catalogmetadata/filter/bundle_predicates.go
  • internal/operator-controller/catalogmetadata/filter/bundle_predicates_test.go
  • internal/operator-controller/catalogmetadata/filter/successors.go
  • internal/operator-controller/catalogmetadata/filter/successors_test.go
  • internal/operator-controller/controllers/clusterextension_controller.go
  • internal/operator-controller/controllers/clusterextension_controller_test.go
  • internal/operator-controller/resolve/catalog.go
  • internal/operator-controller/resolve/catalog_test.go
  • internal/operator-controller/resolve/resolver.go
  • internal/operator-controller/resolve/validation.go
  • internal/operator-controller/resolve/validation_test.go
  • internal/operator-controller/rukpak/bundle/source/source.go
  • internal/operator-controller/rukpak/render/registryv1/generators/generators.go
  • internal/operator-controller/rukpak/render/registryv1/validators/validator.go
  • internal/testing/bundle/fs/bundlefs.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The Go directive and dependencies are updated. Production and test imports across catalog and operator-controller packages now use operator-registry v2 paths. The supplied summaries report no test logic or runtime behavior changes.

Changes: Operator registry v2 migration

Layer / File(s) Summary
Update Go and dependency versions
go.mod
The Go directive changes to 1.26.5. Operator-registry changes to v2.0.0-alpha-3, and other direct and indirect dependencies are upgraded.
Move operator-registry imports to v2
internal/catalogd/..., internal/operator-controller/..., internal/testing/bundle/fs/bundlefs.go
Production and test imports use operator-registry v2 package paths. Test logic and runtime behavior are otherwise unchanged, according to the supplied summaries.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: joelanford, grokspawn, perdasilva

Merge Risk: Minimal · up to 13d9a

The migration compiles in the inspected packages with no established behavior mismatch, so it is mergeable subject to normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly summarizes the main changes: updating the API dependency to v0.46.0 and migrating to operator-registry v2 alpha-3.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description has a clear summary of the change: updating github.com/operator-framework/api to v0.46.0, migrating operator-registry imports to the v2 module at v2.0.0-alpha-3, and advancing the Go v…
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 30 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description has a clear summary of the change: updating github.com/operator-framework/api to v0.46.0, migrating operator-registry imports to the v2 module at v2.0.0-alpha-3, and advancing the Go version to 1.26.5 because registry v2 requires it. It also lists validation steps the author ran and marks two reviewer checklist items. It does not link a related GitHub issue, and the API Go Documentation and title-prefix requirements are not addressed. The core content is present, so the description is mostly complete.

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tmshort tmshort added dependencies Pull requests that update a dependency file go Pull requests that update Go code go-verdiff-override labels Oct 28, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code go-verdiff-override

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant