-
Notifications
You must be signed in to change notification settings - Fork 0
[#676] Profile 탭을 ProfileTab 모듈로 분리한다 #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0432920
chore: ProfileTab target 추가
opficdev cd9e638
refactor: Profile 관련 화면 흐름을 ProfileTab으로 이동
opficdev 6e641a3
chore: Profile 테스트를 ProfileTab으로 이동
opficdev 0c32e65
refactor: Profile 하위 내비게이션을 ProfileTab으로 이동
opficdev 6c131bf
chore: ProfileTab 테스트 지원 타입 복구
opficdev 8f4153a
chore: Tuist 모듈 그래프 갱신
opficdev 1f305fb
fix: DependencyValues 키 충돌 수정
opficdev 3845bde
refactor: Profile 목적지 뷰 생성 로직 공통화
opficdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| parent_config: ../../../../.swiftlint.yml |
2 changes: 1 addition & 1 deletion
2
...ntation/Sources/Profile/HeatmapView.swift → ...fileTab/Sources/Profile/HeatmapView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // HeatmapView.swift | ||
| // Presentation | ||
| // ProfileTab | ||
| // | ||
| // Created by 최윤진 on 3/2/26. | ||
| // | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
...Profile/ProfileFeature+Dependencies.swift → ...Profile/ProfileFeature+Dependencies.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // ProfileFeature+Dependencies.swift | ||
| // Presentation | ||
| // ProfileTab | ||
| // | ||
| // Created by opfic on 6/15/26. | ||
| // | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
...ources/Profile/ProfileFeature+State.swift → ...ources/Profile/ProfileFeature+State.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // ProfileFeature+State.swift | ||
| // Presentation | ||
| // ProfileTab | ||
| // | ||
| // Created by opfic on 6/15/26. | ||
| // | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...urces/Profile/ProfileHeatmapBuilder.swift → ...urces/Profile/ProfileHeatmapBuilder.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // ProfileHeatmapBuilder.swift | ||
| // Presentation | ||
| // ProfileTab | ||
| // | ||
| // Created by opfic on 6/15/26. | ||
| // | ||
|
|
||
94 changes: 94 additions & 0 deletions
94
Application/Presentation/ProfileTab/Sources/Profile/ProfileRegularDetailView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| // | ||
| // ProfileRegularDetailView.swift | ||
| // ProfileTab | ||
| // | ||
| // Created by opfic on 7/6/26. | ||
| // | ||
|
|
||
| import SwiftUI | ||
| import PresentationShared | ||
|
|
||
| public struct ProfileRegularDetailView: View { | ||
| let coordinator: ProfileViewCoordinator | ||
|
|
||
| public init(coordinator: ProfileViewCoordinator) { | ||
| self.coordinator = coordinator | ||
| } | ||
|
|
||
| public var body: some View { | ||
| NavigationStack(path: navigationPath) { | ||
| Group { | ||
| if let route = coordinator.router.root { | ||
| ProfileDestinationView( | ||
| route: route, | ||
| coordinator: coordinator, | ||
| identifiesActivityDetail: true | ||
| ) | ||
| } else { | ||
| ContentUnavailableView( | ||
| String(localized: "profile_select_detail"), | ||
| systemImage: "person.crop.circle" | ||
| ) | ||
| } | ||
| } | ||
| .navigationDestination(for: ProfileRoute.self) { route in | ||
| ProfileDestinationView( | ||
| route: route, | ||
| coordinator: coordinator, | ||
| identifiesActivityDetail: true | ||
| ) | ||
| } | ||
| } | ||
| .background(Color(.systemGroupedBackground).ignoresSafeArea()) | ||
| } | ||
|
|
||
| private var navigationPath: Binding<[ProfileRoute]> { | ||
| Binding( | ||
| get: { coordinator.router.detailPath }, | ||
| set: { coordinator.router.detailPath = $0 } | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| struct ProfileDestinationView: View { | ||
| let route: ProfileRoute | ||
| let coordinator: ProfileViewCoordinator | ||
| let identifiesActivityDetail: Bool | ||
|
|
||
| init( | ||
| route: ProfileRoute, | ||
| coordinator: ProfileViewCoordinator, | ||
| identifiesActivityDetail: Bool = false | ||
| ) { | ||
| self.route = route | ||
| self.coordinator = coordinator | ||
| self.identifiesActivityDetail = identifiesActivityDetail | ||
| } | ||
|
|
||
| var body: some View { | ||
| switch route { | ||
| case .settings: | ||
| SettingsView(store: coordinator.settingsStore) | ||
| .environment(coordinator.router) | ||
| case .activity(let todoId): | ||
| activityDetailView(todoId: todoId) | ||
| case .theme: | ||
| @Bindable var settingsStore = coordinator.settingsStore | ||
| ThemeView(theme: $settingsStore.theme) | ||
| case .pushNotification: | ||
| PushNotificationSettingsView(store: coordinator.makePushNotificationSettingsStore()) | ||
| case .account: | ||
| AccountView(store: coordinator.makeAccountStore()) | ||
| } | ||
| } | ||
|
|
||
| @ViewBuilder | ||
| private func activityDetailView(todoId: String) -> some View { | ||
| if identifiesActivityDetail { | ||
| TodoDetailView(store: coordinator.makeTodoDetailStore(todoId: todoId)) | ||
| .id(todoId) | ||
| } else { | ||
| TodoDetailView(store: coordinator.makeTodoDetailStore(todoId: todoId)) | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...ion/Sources/Settings/AccountFeature.swift → ...Tab/Sources/Settings/AccountFeature.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // AccountFeature.swift | ||
| // Presentation | ||
| // ProfileTab | ||
| // | ||
| // Created by opfic on 6/11/26. | ||
| // | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
...tation/Sources/Settings/AccountView.swift → ...ileTab/Sources/Settings/AccountView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // AccountView.swift | ||
| // Presentation | ||
| // ProfileTab | ||
| // | ||
| // Created by opfic on 5/14/25. | ||
| // | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
...ngs/PushNotificationSettingsFeature.swift → ...ngs/PushNotificationSettingsFeature.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // PushNotificationSettingsFeature.swift | ||
| // Presentation | ||
| // ProfileTab | ||
| // | ||
| // Created by opfic on 6/12/26. | ||
| // | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
...ttings/PushNotificationSettingsView.swift → ...ttings/PushNotificationSettingsView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // PushNotificationSettingsView.swift | ||
| // Presentation | ||
| // ProfileTab | ||
| // | ||
| // Created by opfic on 5/14/25. | ||
| // | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...ation/Sources/Settings/SettingsView.swift → ...leTab/Sources/Settings/SettingsView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // SettingsView.swift | ||
| // Presentation | ||
| // ProfileTab | ||
| // | ||
| // Created by opfic on 5/6/25. | ||
| // | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
...entation/Sources/Settings/ThemeView.swift → ...ofileTab/Sources/Settings/ThemeView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // ThemeView.swift | ||
| // Presentation | ||
| // ProfileTab | ||
| // | ||
| // Created by opfic on 5/6/25. | ||
| // | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
.../Structure/Profile/ActivityKindItem.swift → .../Structure/Profile/ActivityKindItem.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // ActivityKindItem.swift | ||
| // Presentation | ||
| // ProfileTab | ||
| // | ||
| // Created by opfic on 4/4/26. | ||
| // | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
...ructure/Profile/HeatmapActivityItem.swift → ...ructure/Profile/HeatmapActivityItem.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // HeatmapActivityItem.swift | ||
| // Presentation | ||
| // ProfileTab | ||
| // | ||
| // Created by opfic on 3/2/26. | ||
| // | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.