-
Notifications
You must be signed in to change notification settings - Fork 0
[#696] Presentation과 Entry target 책임을 분리한다 #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1cb559b
refactor: Presentation Entry 하위 경로 정리
opficdev 9ffcccf
test: PresentationShared 테스트 target 분리
opficdev 16ea79f
refactor: LoadingState를 PresentationShared로 이동
opficdev 0811248
chore: Presentation Sources 잔여 파일 제거
opficdev 1b8d4e7
docs: 소셜 로그인 취소 판정 위치 갱신
opficdev db7ee9d
docs: Presentation Entry 구조 문서 갱신
opficdev a24d8a1
ci: Presentation 테스트 경로 갱신
opficdev 67acd54
refactor: Entry target 분리
opficdev 510519f
ci: Presentation 테스트 scheme 갱신
opficdev 6a17132
docs: Presentation Entry 구조 갱신
opficdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| parent_config: ../../../../.swiftlint.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...entation/Sources/Login/LoginFeature.swift → ...on/Entry/Sources/Login/LoginFeature.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...resentation/Sources/Login/LoginView.swift → ...ation/Entry/Sources/Login/LoginView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // LoginView.swift | ||
| // Presentation | ||
| // Entry | ||
| // | ||
| // Created by opfic on 12/30/24. | ||
| // | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
...esentation/Sources/Main/MainFeature.swift → ...tion/Entry/Sources/Main/MainFeature.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // MainFeature.swift | ||
| // Presentation | ||
| // Entry | ||
| // | ||
| // Created by opfic on 6/16/26. | ||
| // | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
.../Presentation/Sources/Main/MainView.swift → ...ntation/Entry/Sources/Main/MainView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // MainView.swift | ||
| // Presentation | ||
| // Entry | ||
| // | ||
| // Created by opfic on 5/8/25. | ||
| // | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
...esentation/Sources/Root/RootFeature.swift → ...tion/Entry/Sources/Root/RootFeature.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // RootFeature.swift | ||
| // Presentation | ||
| // Entry | ||
| // | ||
| // Created by opfic on 6/17/26. | ||
| // | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
.../Presentation/Sources/Root/RootView.swift → ...ntation/Entry/Sources/Root/RootView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // RootView.swift | ||
| // Presentation | ||
| // Entry | ||
| // | ||
| // Created by opfic on 5/2/25. | ||
| // | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
...resentation/Sources/Routing/MainTab.swift → ...ation/Entry/Sources/Routing/MainTab.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // MainTab.swift | ||
| // Presentation | ||
| // Entry | ||
| // | ||
| // Created by opfic on 4/30/26. | ||
| // | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // | ||
| // SharedExports.swift | ||
| // Entry | ||
| // | ||
| // Created by opfic on 7/2/26. | ||
| // | ||
|
|
||
| @_exported import PresentationShared |
2 changes: 1 addition & 1 deletion
2
...es/WindowGroup/TodoEditorWindowView.swift → ...es/WindowGroup/TodoEditorWindowView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // TodoEditorWindowView.swift | ||
| // Presentation | ||
| // Entry | ||
| // | ||
| // Created by opfic on 5/31/26. | ||
| // | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
...s/WindowGroup/TodoWindowCoordinator.swift → ...s/WindowGroup/TodoWindowCoordinator.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // TodoWindowCoordinator.swift | ||
| // Presentation | ||
| // Entry | ||
| // | ||
| // Created by opfic on 5/31/26. | ||
| // | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| parent_config: ../../../../.swiftlint-tests.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...ntation/Tests/Root/RootFeatureTests.swift → ...n/Entry/Tests/Root/RootFeatureTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // | ||
| // RootFeatureTests.swift | ||
| // PresentationTests | ||
| // EntryTests | ||
| // | ||
| // Created by opfic on 6/17/26. | ||
| // | ||
|
|
||
66 changes: 66 additions & 0 deletions
66
Application/Presentation/Entry/Tests/Support/EntryTestSupport.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| // | ||
| // EntryTestSupport.swift | ||
| // EntryTests | ||
| // | ||
| // Created by opfic on 7/6/26. | ||
| // | ||
|
|
||
| import Domain | ||
|
|
||
| @MainActor | ||
| func waitUntil( | ||
| timeout: Duration = .seconds(1), | ||
| pollInterval: Duration = .milliseconds(20), | ||
| _ condition: @escaping () -> Bool | ||
| ) async { | ||
| let continuousClock = ContinuousClock() | ||
| let deadline = continuousClock.now + timeout | ||
|
|
||
| while !condition() && continuousClock.now < deadline { | ||
| try? await Task.sleep(for: pollInterval) | ||
| } | ||
| } | ||
|
|
||
| final class SignInUseCaseSpy: SignInUseCase { | ||
| var error: Error? | ||
| var signedIn = true | ||
| var shouldSuspend = false | ||
| private(set) var calledProviders = [AuthProvider]() | ||
| private(set) var successfulProviders = [AuthProvider]() | ||
| private var continuation: CheckedContinuation<Void, Never>? | ||
| private var shouldResume = false | ||
|
|
||
| func execute(_ provider: AuthProvider) async throws -> Bool { | ||
| calledProviders.append(provider) | ||
|
|
||
| if shouldSuspend { | ||
| await withCheckedContinuation { continuation in | ||
| if shouldResume { | ||
| shouldResume = false | ||
| continuation.resume() | ||
| } else { | ||
| self.continuation = continuation | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if let error { | ||
| throw error | ||
| } | ||
|
|
||
| if signedIn { | ||
| successfulProviders.append(provider) | ||
| } | ||
|
|
||
| return signedIn | ||
| } | ||
|
|
||
| func resume() { | ||
| guard let continuation else { | ||
| shouldResume = true | ||
| return | ||
| } | ||
| self.continuation = nil | ||
| continuation.resume() | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Application/Presentation/PresentationShared/Tests/.swiftlint.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| parent_config: ../../../../.swiftlint-tests.yml |
5 changes: 2 additions & 3 deletions
5
...on/Tests/Common/LoadingFeatureTests.swift → ...ed/Tests/Common/LoadingFeatureTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 2 additions & 3 deletions
5
...sts/Search/SearchFeatureTestDoubles.swift → ...sts/Search/SearchFeatureTestDoubles.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 2 additions & 3 deletions
5
...ion/Tests/Search/SearchFeatureTests.swift → ...red/Tests/Search/SearchFeatureTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 2 additions & 3 deletions
5
...n/Tests/Todo/TodoDetailFeatureTests.swift → ...d/Tests/Todo/TodoDetailFeatureTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.