[#706] 계정별로 캐시용 디렉토리를 분리한다#711
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트는 웹페이지 이미지 캐시를 계정별(accountID)로 격리하여 관리하도록 개선합니다. WebPageImageStore 및 WebPageMetadataService 프로토콜과 구현체에 accountID 매개변수를 추가하고, AuthService를 통해 획득한 사용자 UID를 기반으로 SHA256 해시된 계정별 서브디렉토리에 이미지를 저장하도록 변경했습니다. 또한 관련 테스트 코드를 추가하고 불필요한 기존 테스트 파일들을 정리했습니다. 제공된 리뷰 코멘트가 없으므로 추가로 제시할 피드백은 없습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
WebPageImageStore와WebPageMetadataService에accountIDscope 전달 추가WebPageRepositoryImpl와WebPageImageRepositoryImpl에서 현재AuthService.uid기준으로 캐시 저장, 조회, 삭제 연결WebPageImageStoreImpl에서 계정 ID 해시 기반 하위 디렉토리 사용🔍 상세
accountID전달 경로 정리webPageImages경로를 유지해 기존 동작 보존DomainTests타깃 제거📸 영상 / 이미지 (Optional)