[#763] Google 인증을 GoogleSignIn serverAuthCode 흐름으로 전환한다 - #771
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78a1ff9335
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
회원 탈퇴에서도 Google 로컬 세션을 정리하세요
Google로 로그인하거나 계정을 연결한 사용자가 회원 탈퇴에 성공하면 이 경로는 서버의 access token만 폐기하고, 이후 AuthenticationRepositoryImpl.delete()도 Firebase 세션만 정리하므로 GIDSignIn의 로컬 세션이 남습니다. 기존 로그아웃 지적과 달리 현재 signOut()은 모든 provider를 순회하지만 회원 탈퇴 경로에서는 여전히 GIDSignIn.sharedInstance.signOut()이 호출되지 않는다는 점이 새 근거이며, 탈퇴 후 다시 Google 인증을 시작하면 삭제한 계정의 SDK 상태에서 시작될 수 있으므로 성공한 탈퇴 경로에서도 이를 정리해야 합니다.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
opficdev
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 458e807e7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
🔗 연관된 이슈
🎯 의도
serverAuthCode만 전달하는 인증 구조로 전환📝 작업 내용
📌 요약
GoogleSignIn패키지와 앱 URL 콜백 처리 추가serverAuthCode기반 API로 전환🔍 상세
GoogleSignIn 연동
GoogleSignIn패키지 의존성과 Infra 모듈 연결 추가AppDelegate.application(_:open:options:)에서 GoogleSignIn URL 콜백 처리TopViewControllerProvider를 통한 GoogleSignIn 표시 화면 탐색GIDSignIn.sharedInstance.signOut()호출 추가로그인 및 계정 연결
serverAuthCode를POST /auth/google/authorization-code/custom-token으로 전달serverAuthCode를PUT /auth/google/authorization-code/account-link로 전달기존 인증 흐름 정리
OAuthAuthenticationTicketRequester를 사용하던 Google 전용 ticket/session 호출 제거환경 설정 및 배포 검증
Info.plist에GIDClientID,GIDServerClientID, reversed client ID URL scheme 연결CLIENT_ID,GID_SERVER_CLIENT_ID,REVERSED_CLIENT_ID확인 추가GIDClientID와 bundledGoogleService-Info.plist의CLIENT_ID일치 여부 확인📸 영상 / 이미지 (Optional)