Skip to content

Merge develop into infrahub-develop - #1370

Merged
infrahub-github-bot-app[bot] merged 2 commits into
infrahub-developfrom
develop
Sep 17, 2026
Merged

infrahub-github-bot-app[bot] merged 2 commits into
infrahub-developfrom
develop

Conversation

@infrahub-github-bot-app

@infrahub-github-bot-app infrahub-github-bot-app Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Merging develop into infrahub-develop after merging pull request #1369.


Summary by cubic

Merges develop into infrahub-develop, bringing the structured schema validation errors. Schema validation errors previously exposed only field and message; they now also carry loc, input, and reason as separate fields, so consumers can report violations without parsing the message text. For missing fields, input is the enclosing object.

Written for commit ff707a8. Summary will update on new commits.

Review in cubic

polmichel and others added 2 commits September 17, 2026 19:30
…1357)

* feat(schema): expose location, value and reason on validation error details

Every entry of `SchemaValidationResult.errors` now carries `loc` (the
field location as a tuple of keys and indexes), `input` (the value
received there) and `reason` (the wording alone), next to the unchanged
`field` and `message`, which are rendered from these parts by a single
helper. A consumer can report or forward each violation in a structured
form without parsing the message text.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* test(schema): assert field is the dotted rendering of loc on a concrete error

The parametrized check compared field and loc by rewriting brackets into
dots, which hid the rule it was testing. A dedicated test now shows one
nested error with its location tuple and rendered path side by side.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* test(schema): check field against loc for every rejected case

Drops a test that repeated the unknown-field detail test, asserts the
rendered field on the out-of-enum detail test, and restores the
field/loc consistency check across all unknown-field and out-of-enum
cases through a small helper that spells out the expected rendering.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Merge stable into develop
@infrahub-github-bot-app
infrahub-github-bot-app Bot requested a review from a team as a code owner September 17, 2026 18:05
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 17, 2026

Copy link
Copy Markdown

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff707a8
Status: ✅  Deploy successful!
Preview URL: https://1448a1ef.infrahub-sdk-python.pages.dev
Branch Preview URL: https://develop.infrahub-sdk-python.pages.dev

View logs

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                Coverage Diff                @@
##           infrahub-develop    #1370   +/-   ##
=================================================
  Coverage             86.28%   86.28%           
=================================================
  Files                   149      149           
  Lines                 14537    14541    +4     
  Branches               1995     1994    -1     
=================================================
+ Hits                  12543    12547    +4     
  Misses                 1431     1431           
  Partials                563      563           
Flag Coverage Δ
integration-tests 43.57% <0.00%> (-0.02%) ⬇️
python-3.10 61.53% <60.00%> (-0.04%) ⬇️
python-3.11 61.55% <60.00%> (-0.02%) ⬇️
python-3.12 61.55% <60.00%> (-0.01%) ⬇️
python-3.13 61.55% <60.00%> (-0.02%) ⬇️
python-3.14 61.55% <60.00%> (-0.02%) ⬇️
python-filler-3.12 21.76% <40.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/schema/validate.py 94.68% <100.00%> (+0.23%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@infrahub-github-bot-app
infrahub-github-bot-app Bot merged commit 68f742b into infrahub-develop Sep 17, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant