Conversation
CoreNumberPool gains a ranges relationship and its start_range and end_range become optional; the new CoreNumberPoolRange kind is added. Generated from the Infrahub core models, not written by hand. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TgXERZQRu7W5V8zCyUEAVA
Deploying infrahub-sdk-python with
|
| Latest commit: |
40e6d8c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://edf03355.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pmi-number-pool-range-protoc.infrahub-sdk-python.pages.dev |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
… kind The generator builds its import line by introspecting infrahub_sdk.protocols, so regenerating that module in 100d6b3 to add CoreNumberPoolRange changed the output for every user schema. The golden fixtures still carried the previous import line, failing test_render_user_schema_matches_golden. Only line 9 changes in each fixture, gaining CoreNumberPoolRange and CoreNumberPoolRangeSync. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## infrahub-develop #1371 +/- ##
====================================================
- Coverage 86.28% 86.05% -0.23%
====================================================
Files 149 149
Lines 14537 14338 -199
Branches 1995 1958 -37
====================================================
- Hits 12543 12339 -204
Misses 1431 1431
- Partials 563 568 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Infrahub gains a
CoreNumberPoolRangecore kind, andCoreNumberPoolgains arangesrelationship while its
start_rangeandend_rangebecome optional.Needed by opsmill/infrahub#10682.
What changed
infrahub_sdk/protocols.pyonly, regenerated.Relates to
Infrahub companion PR: opsmill/infrahub#10682
🤖 Generated with Claude Code
https://claude.ai/code/session_01TgXERZQRu7W5V8zCyUEAVA
Summary by cubic
Regenerates
infrahub_sdk/protocols.pyto match the newCoreNumberPoolRangekind and updatedCoreNumberPoolmodel, and refreshes the generator's golden fixtures that gained the new range classes from the regenerated import line. This keeps generated protocols in sync with Infrahub sobackend-validate-generatedpasses before the submodule pointer moves.CoreNumberPool.start_rangeandend_rangebecomeIntegerOptional, and arangesrelationship is added.CoreNumberPoolRangeandCoreNumberPoolRangeSyncwithstart,end,allocation_weight, andpool.Written for commit 40e6d8c. Summary will update on new commits.