Skip to content

Set sys.flags.debug to 0 by default #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hippi345 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Set sys.flags.debug to 0 by default #1219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions graalpython/com.oracle.graal.python.test/src/tests/test_sys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,3 +133,9 @@ def test_getwindowsversion_java_backend(self):
capture_output=True, text=True, check=True,
)
self.assertEqual(result.stdout.splitlines(), [str(expected), str(expected)])


class SysFlagsTests(unittest.TestCase):
def test_debug_is_zero_by_default(self):
# CPython sets sys.flags.debug only when -d is given, not from -O.
self.assertEqual(sys.flags.debug, 0)
2 changes: 1 addition & 1 deletion ...m.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/SysModuleBuiltins.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,7 @@ public void postInitialize0(Python3Core core) {
PList sysPaths = PFactory.createList(language, path);
sys.setAttribute(tsInternedLiteral("path"), sysPaths);
sys.setAttribute(tsInternedLiteral("flags"), PFactory.createStructSeq(language, SysModuleBuiltins.FLAGS_DESC,
PInt.intValue(!language.getEngineOption(PythonOptions.PythonOptimizeFlag)), // debug
0, // debug
PInt.intValue(context.getOption(PythonOptions.InspectFlag)), // inspect
PInt.intValue(context.getOption(PythonOptions.TerminalIsInteractive)), // interactive
PInt.intValue(language.getEngineOption(PythonOptions.PythonOptimizeFlag)), // optimize
Expand Down