Skip to content

fix: forward Responses additional tools - #96

Merged
orangeboyChen merged 2 commits into
mainfrom
codex/fix-responses-additional-tools
Sep 3, 2026
Merged

fix: forward Responses additional tools#96
orangeboyChen merged 2 commits into
mainfrom
codex/fix-responses-additional-tools

Conversation

@orangeboyChen

Copy link
Copy Markdown
Owner

Extract input additional_tools declarations for /v1/responses, merge them with top-level tools, and omit metadata items from transcript messages. Adds regression coverage for namespace tool flattening. Validated with lint, format check, typecheck, test coverage (93.5%), test:ci, and patch coverage (100%). Local build is blocked by Turbopack local-port permissions in this environment.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08f46ce2a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/server/proxy/responses.ts
Comment thread tests/server/units.test.ts
Comment thread lib/server/proxy/responses.ts Outdated
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.77%. Comparing base (ec7b039) to head (972aaa0).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   94.74%   94.77%   +0.02%     
==========================================
  Files          21       21              
  Lines        4246     4251       +5     
  Branches     1233     1238       +5     
==========================================
+ Hits         4023     4029       +6     
+ Misses        223      222       -1     
Flag Coverage Δ
unittests 94.77% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orangeboyChen
orangeboyChen force-pushed the codex/fix-responses-additional-tools branch from 08f46ce to 972aaa0 Compare September 3, 2026 16:15
@orangeboyChen
orangeboyChen enabled auto-merge (squash) September 3, 2026 16:15
@orangeboyChen
orangeboyChen merged commit deee7db into main Sep 3, 2026
7 checks passed
@orangeboyChen
orangeboyChen deleted the codex/fix-responses-additional-tools branch September 3, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants