Skip to content

chore(deps-dev): Bump the typescript group across 1 directory with 2 updates - #262

Merged
oratis merged 3 commits into
mainfrom
dependabot/npm_and_yarn/typescript-71c6988b94
Aug 25, 2026
Merged

chore(deps-dev): Bump the typescript group across 1 directory with 2 updates#262
oratis merged 3 commits into
mainfrom
dependabot/npm_and_yarn/typescript-71c6988b94

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps the typescript group with 2 updates in the / directory: typescript-eslint and @types/vscode.

Updates typescript-eslint from 8.65.0 to 8.67.0

Release notes

Sourced from typescript-eslint's releases.

v8.67.0

8.67.0 (2026-08-10)

🚀 Features

  • typescript-eslint: export basic globs for using tseslint (#12105)

❤️ Thank You

See GitHub Releases for more information.

You can read about our versioning strategy and releases on our website.

v8.66.0

8.66.0 (2026-08-03)

🚀 Features

  • typescript-estree: handle import.defer() as ImportExpression (#12609)

🩹 Fixes

  • eslint-plugin: [no-unnecessary-type-conversion] ignore shadowed built-ins (#12590)
  • eslint-plugin: [prefer-nullish-coalescing] handle shadowed Boolean calls (#12591)
  • eslint-plugin: [no-useless-default-assignment] don't report defaults used by other overloads (#12607)
  • eslint-plugin: [no-unnecessary-type-parameters] check MappedType key remapping (#12588)
  • eslint-plugin: [class-literal-property-style] preserve type annotations and don't drop decorators (#12617)
  • website: list onUnsupportedTypeScriptVersion in parser options (#12585)

❤️ Thank You

See GitHub Releases for more information.

You can read about our versioning strategy and releases on our website.

Changelog

Sourced from typescript-eslint's changelog.

8.67.0 (2026-08-10)

🚀 Features

  • typescript-eslint: export basic globs for using tseslint (#12105)

❤️ Thank You

See GitHub Releases for more information.

You can read about our versioning strategy and releases on our website.

8.66.0 (2026-08-03)

This was a version bump only for typescript-eslint to align it with other projects, there were no code changes.

See GitHub Releases for more information.

You can read about our versioning strategy and releases on our website.

Commits

Updates @types/vscode from 1.120.0 to 1.125.0

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Aug 10, 2026
@dependabot
chore(deps-dev): Bump the typescript group across 1 directory with 2 …
7885633 
…updates

Bumps the typescript group with 2 updates in the / directory: [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) and [@types/vscode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/vscode).


Updates `typescript-eslint` from 8.65.0 to 8.67.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.67.0/packages/typescript-eslint)

Updates `@types/vscode` from 1.120.0 to 1.125.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/vscode)

---
updated-dependencies:
- dependency-name: "@types/vscode"
  dependency-version: 1.125.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript
- dependency-name: typescript-eslint
  dependency-version: 8.66.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot changed the title chore(deps-dev): Bump the typescript group with 2 updates chore(deps-dev): Bump the typescript group across 1 directory with 2 updates Aug 17, 2026
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/typescript-71c6988b94 branch from 468de28 to 7885633 Compare August 17, 2026 04:35
oratis and others added 2 commits August 25, 2026 23:02
@oratis
Merge remote-tracking branch 'origin/main' into dependabot/npm_and_ya…
816ef02 
…rn/typescript-71c6988b94
@oratis @claude
fix(vscode): keep @types/vscode at the engine floor, and pin it there
65b8d9e 
The typescript group swept `@types/vscode` from ^1.85.0 to ^1.125.0 along
with typescript-eslint, and `vsce package` refused the build:

  ERROR  @types/vscode ^1.125.0 greater than engines.vscode ^1.85.0

That check is right. `engines.vscode` is the OLDEST editor this extension
supports; types newer than it let a call added in a later VS Code
typecheck cleanly and then fail on the editor we promised to run on.
Taking the bump means dropping every VS Code between 1.85 and 1.125,
which is a support decision, not a dependency update.

typescript-eslint ^8.67.0 is kept — it was the half of the group that
had nothing wrong with it.

Pinned exactly rather than restored to `^1.85.0`: the caret was already
resolving to 1.120.0 on main, so the compiler was seeing 35 minor
versions of API the extension does not claim to support. Verified the
floor is honest — `apps/vscode` typechecks against exactly 1.85.0 with
no errors — so the pin costs nothing and makes the declaration
enforceable.

Guarded twice: dependabot is told to ignore the dependency, with the
reason written down, and `scripts/vscode-types-engine.test.ts` fails the
unit suite in seconds rather than waiting for `release:check` to fail
minutes into a full workspace build.

release:check exits 0; VSIX packages at 199.19 KB.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@oratis

oratis commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Reviewed, fixed, and verified locally against current main. Pushed 65b8d9e.

Why it was red

The group swept @types/vscode from ^1.85.0 to ^1.125.0 alongside typescript-eslint, and vsce package refused the build:

ERROR  @types/vscode ^1.125.0 greater than engines.vscode ^1.85.0

That check is correct and should not be worked around. engines.vscode states the oldest editor this extension supports. Types newer than the engine let a call added in a later VS Code typecheck cleanly and then throw on the editor we promised to run on. The two ways out — raise engines.vscode, or hold the types — are not equivalent: the first drops support for every VS Code between 1.85 and 1.125, which is a product decision, not something a dependency PR should make on the way past.

So: typescript-eslint ^8.67.0 kept, @types/vscode held at the floor. That was the half of the group with nothing wrong with it.

One thing found while fixing it

Restoring ^1.85.0 would have left the actual problem in place. The caret was already resolving to 1.120.0 on main — the compiler has been seeing 35 minor versions of API surface the extension does not claim to support, and vsce never complained because it reads the specifier, not the resolved version. The floor was declared but not enforced.

Pinned exactly ("1.85.0", no caret) instead. Checked first that the floor is honest: apps/vscode typechecks against exactly 1.85.0 with zero errors, so nothing in the extension actually needs a newer API and the pin costs nothing.

Guarded twice

  • .github/dependabot.yml ignores @types/vscode, with the reason written next to it. Otherwise this PR returns next Monday.
  • scripts/vscode-types-engine.test.ts fails the unit suite in seconds with a message naming the trade-off, instead of surfacing minutes into release:check after a full workspace build. Verified it fires: re-applying ^1.125.0 fails with @types/vscode ^1.125.0 is newer than engines.vscode ^1.85.0.

Verification

typecheck, lint, format, docs clean; 1672 tests pass, 19 skipped; pnpm release:check exits 0 and packages the VSIX at 199.19 KB — the step that was failing.

@oratis
oratis merged commit b5f9dfc into main Aug 25, 2026
6 checks passed
@oratis
oratis deleted the dependabot/npm_and_yarn/typescript-71c6988b94 branch August 25, 2026 15:11
@oratis oratis mentioned this pull request Aug 25, 2026
Merged
oratis added a commit that referenced this pull request Aug 25, 2026
@oratis @claude
chore: repair the lockfile after merging main
297ab4d 
This branch was cut before #262 and #263 landed, so merging main produced
a pnpm-lock.yaml that git resolved cleanly and pnpm rejected:

  ERR_PNPM_LOCKFILE_MISSING_DEPENDENCY  Broken lockfile: no entry for
  'eslint@10.8.0(jiti@1.21.7)' in pnpm-lock.yaml

which is why CI failed at "Install dependencies" before running a single
check. Regenerated with --no-frozen-lockfile and re-verified with
--frozen-lockfile, the flag CI actually uses.

eslint 10.9.0 adds no findings on top of the nine that #263 fixed:
typecheck, lint, format, docs clean; 1672 tests pass, 19 skipped.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@oratis oratis mentioned this pull request Aug 25, 2026
Merged
oratis added a commit that referenced this pull request Aug 25, 2026
@dependabot @oratis @claude
chore(deps-dev): Bump eslint from 10.8.0 to 10.9.0 in the eslint group (
bbb2ac2 
#276)

* chore(deps-dev): Bump eslint from 10.8.0 to 10.9.0 in the eslint group

Bumps the eslint group with 1 update: [eslint](https://github.com/eslint/eslint).


Updates `eslint` from 10.8.0 to 10.9.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v10.8.0...v10.9.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-version: 10.9.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: eslint
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: repair the lockfile after merging main

This branch was cut before #262 and #263 landed, so merging main produced
a pnpm-lock.yaml that git resolved cleanly and pnpm rejected:

  ERR_PNPM_LOCKFILE_MISSING_DEPENDENCY  Broken lockfile: no entry for
  'eslint@10.8.0(jiti@1.21.7)' in pnpm-lock.yaml

which is why CI failed at "Install dependencies" before running a single
check. Regenerated with --no-frozen-lockfile and re-verified with
--frozen-lockfile, the flag CI actually uses.

eslint 10.9.0 adds no findings on top of the nine that #263 fixed:
typecheck, lint, format, docs clean; 1672 tests pass, 19 skipped.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: oratis <wangharp@gmail.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 25, 2026
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@oratis