Repository navigation
feat: FAQ page with FAQPage schema - #33
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/faqanswering five questions: is it free, limits, offline, currencies, export. It reuses the existingFaqblock andfaqJsonLd, so the page has FAQPage structured data that matches the visible text./faqis added tositemap.xml, so the "FAQ page in sitemap" check passes once this is deployed.Where the answers come from
MAX_AMOUNT_CENTS(21,474,836.47),FILE_SIZE_LIMIT(5 MB) and quick split'sMAX_PEOPLE(20). I found no cap on groups or friends. The Splitwise "4 per day" figure is the same sourced claim the landing page and blog already make.currency.ts). Balances are kept per currency, groups have a default currency, there's no exchange-rate conversion, and a quick split uses one currency.getExpensesWithFriendincludes expenses in shared groups) and the JSON "Download splitpro data" on the Account page (friends, groups, balances). The page says there's no group CSV export yet.How I checked it
npx prettier --write,npx tsc --noEmit -p .(clean) andSKIP_ENV_VALIDATION=1 pnpm lint(no new warnings)next dev:/faqreturns 200 with the FAQPage JSON-LD, and/sitemap.xmllistshttps://splitpro.app/faq